mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org,
	alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 2/5] revoke: core code
Date: Fri, 16 Mar 2007 22:37:57 +0200	[thread overview]
Message-ID: <84144f020703161337o3a6519cfn34d4b2620062264d@mail.gmail.com> (raw)
In-Reply-To: <20070316042600.3e1bd424.akpm@linux-foundation.org>

On 3/16/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> However, modifying i_size like this might be a problem - the inode could be
> dirty and it'll get written to disk!  Perhaps we could change i_size_read()
> to cheat and to return zero if there's a revoke in progress.

I don't think we can actually abuse i_size_read() in any sane manner
because the inode needs to be usable for anyone who just did open(2)
after revoke or whoever called frevoke(2).

What we could do is add a "I am revoked" flag to struct file which
blocks any future ->readpage, ->readpages, and ->direct_IO on the
file. Alternatively, we could change the ->f_mapping to point to an
address space that has "revoked address space" operations. Hmm.

  parent reply	other threads:[~2007-03-16 20:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-11 11:30 Pekka J Enberg
2007-03-16  1:34 ` Andrew Morton
2007-03-16  6:44   ` Pekka Enberg
2007-03-16 11:26     ` Andrew Morton
2007-03-16 11:44       ` Pekka J Enberg
2007-03-16 12:26         ` Andrew Morton
2007-03-16 14:45           ` Pekka J Enberg
2007-03-16 14:58           ` Alan Cox
2007-03-16 14:27             ` Pekka Enberg
2007-03-16 14:46               ` Pekka Enberg
2007-03-16 14:30             ` Pekka Enberg
2007-03-16 20:37           ` Pekka Enberg [this message]
2007-03-16 20:54             ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84144f020703161337o3a6519cfn34d4b2620062264d@mail.gmail.com \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®