From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Matt Mackall" <mpm@selenic.com>
Cc: "Paul Mundt" <lethal@linux-sh.org>,
"Christoph Lameter" <clameter@sgi.com>,
linux-kernel@vger.kernel.org, dhowells@redhat.com
Subject: Re: [RFC/PATCH 1/3] SLAB: Add PageSlab checking to ksize()
Date: Thu, 22 May 2008 19:13:56 +0300 [thread overview]
Message-ID: <84144f020805220913g344baedaqb0996adecdadae99@mail.gmail.com> (raw)
In-Reply-To: <1211468502.18026.350.camel@calx>
Hi Matt,
On Thu, May 22, 2008 at 6:01 PM, Matt Mackall <mpm@selenic.com> wrote:
> As I've said several times, ksize() on kmem_cache_alloced objects
> -cannot work- on SLOB. Calling ksize() on something returned by
> kmem_cache_alloc is a categorical error.
Well, it's a historical fact that ksize() worked for both kmalloc()
and kmem_cache_alloc() (see the kernedoc comment in mm/slab.c).
However, I think we should just look at getting rid of ksize()
altogether as it's only (ab)used by the nommu code and few call-sites
that open-code krealloc().
Pekka
next prev parent reply other threads:[~2008-05-22 16:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 18:25 Pekka J Enberg
2008-05-21 23:45 ` Paul Mundt
2008-05-22 4:13 ` Pekka Enberg
2008-05-22 4:17 ` Christoph Lameter
2008-05-22 4:21 ` Pekka Enberg
2008-05-22 4:34 ` Paul Mundt
2008-05-22 4:43 ` Pekka Enberg
2008-05-22 4:55 ` Paul Mundt
2008-05-22 15:01 ` Matt Mackall
2008-05-22 16:13 ` Pekka Enberg [this message]
2008-05-22 16:51 ` Christoph Lameter
2008-05-22 18:31 ` Matt Mackall
2008-05-23 14:23 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020805220913g344baedaqb0996adecdadae99@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=clameter@sgi.com \
--cc=dhowells@redhat.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®