From: Christoph Lameter <clameter@sgi.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Paul Mundt <lethal@linux-sh.org>,
linux-kernel@vger.kernel.org, mpm@selenic.com,
dhowells@redhat.com
Subject: Re: [RFC/PATCH 1/3] SLAB: Add PageSlab checking to ksize()
Date: Wed, 21 May 2008 21:17:24 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0805212116260.19431@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <4834F2E2.3070806@cs.helsinki.fi>
On Thu, 22 May 2008, Pekka Enberg wrote:
> Paul Mundt wrote:
> > This series seems to work ok with all of SLAB/SLUB/SLOB when also
> > applying the kobjsize() patch. Without the kobjsize() patch in place,
> > SLAB and SLUB both work, while SLOB still triggers the >= MAX_ORDER
> > BUG_ON() for page cache pages. Note that this is still an improvement
> > over SLUB blowing up, as it was before, even without the kobjsize()
> > change.
>
> That's probably due to the fact that we use PageSlab for all pages with SLUB
> and for bigblock pages in SLOB with this patch. Christoph, Matt, any
> suggestions how to fix the PageSlab check in nommu btw?
I already posted a patch and commented numerous times. What else needs
to be said? SLUB only uses PageSlab for kmalloc <=4kb.
next prev parent reply other threads:[~2008-05-22 4:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 18:25 Pekka J Enberg
2008-05-21 23:45 ` Paul Mundt
2008-05-22 4:13 ` Pekka Enberg
2008-05-22 4:17 ` Christoph Lameter [this message]
2008-05-22 4:21 ` Pekka Enberg
2008-05-22 4:34 ` Paul Mundt
2008-05-22 4:43 ` Pekka Enberg
2008-05-22 4:55 ` Paul Mundt
2008-05-22 15:01 ` Matt Mackall
2008-05-22 16:13 ` Pekka Enberg
2008-05-22 16:51 ` Christoph Lameter
2008-05-22 18:31 ` Matt Mackall
2008-05-23 14:23 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805212116260.19431@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=dhowells@redhat.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®