mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	mingo@elte.hu, linux-kernel@vger.kernel.org, paulmck@us.ibm.com,
	a.p.zijlstra@chello.nl, "Vegard Nossum" <vegard.nossum@gmail.com>
Subject: Re: [git pull] RCU updates for v2.6.27
Date: Wed, 16 Jul 2008 00:01:42 +0300	[thread overview]
Message-ID: <84144f020807151401s2e37b892q2df007c9e1e3464a@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.1.10.0807151319360.2867@woody.linux-foundation.org>

Hi Linus,

On Tue, 15 Jul 2008 10:38:27 -0700 (PDT)
Linus Torvalds <torvalds@linux-foundation.org> wrote:
>>> Hmm. I really wanted to wait with kmemcheck, which is huge and I'm not
>>> entirely convinced yet.

On Tue, 15 Jul 2008, Andrew Morton wrote:
>> Any particular concerns?

On Tue, Jul 15, 2008 at 11:29 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> It's big, complex and looks fragile. And it reports lots of false
> positives, with big warnings to people to generally not use or make
> reports about itit unless they are already experts. So it looks like
> something pretty specific.
>
> I also want to feel like it actually has been helpful.

Besides catching reads to uninitialized memory, kmemcheck detects
use-after-free now and can be extended to catch red-zone overwrites
*as they happen* which will make debugging kernel memory corruptions
much easier for everybody.

There are now three commits in your tree that fix a real bug reported
by kmemcheck: 8410565f540db87ca938f56f92780d251e4f157d ("ACPICA: Fix
for access to deleted object <regression>"),
adeed48090fc370afa0db8d007748ee72a40b578 ("rc80211_pid: Fix fast_start
parameter handling"), and 62f75532b583c03840f31e40386ce2df73be9ca0
("slub: Initialize per-cpu stats").

So I think it has been helpful and that the infrastructure it adds is
valuable for future debugging aids.

                        Pekka

  reply	other threads:[~2008-07-15 21:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-14 15:20 Ingo Molnar
2008-07-15 17:38 ` Linus Torvalds
2008-07-15 19:15   ` Ingo Molnar
2008-07-15 20:14   ` Vegard Nossum
2008-07-16 17:00     ` Andi Kleen
2008-07-16 17:18       ` Vegard Nossum
2008-07-15 20:15   ` Andrew Morton
2008-07-15 20:29     ` Linus Torvalds
2008-07-15 21:01       ` Pekka Enberg [this message]
2008-07-15 23:06         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84144f020807151401s2e37b892q2df007c9e1e3464a@mail.gmail.com \
    --to=penberg@cs.helsinki.fi \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@us.ibm.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®