mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, paulmck@us.ibm.com,
	a.p.zijlstra@chello.nl, Vegard Nossum <vegard.nossum@gmail.com>
Subject: Re: [git pull] RCU updates for v2.6.27
Date: Tue, 15 Jul 2008 13:29:26 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0807151319360.2867@woody.linux-foundation.org> (raw)
In-Reply-To: <20080715131515.ebdc53d8.akpm@linux-foundation.org>



On Tue, 15 Jul 2008, Andrew Morton wrote:

> On Tue, 15 Jul 2008 10:38:27 -0700 (PDT)
> Linus Torvalds <torvalds@linux-foundation.org> wrote:
> 
> > Hmm. I really wanted to wait with kmemcheck, which is huge and I'm not 
> > entirely convinced yet.
> 
> Any particular concerns?

It's big, complex and looks fragile. And it reports lots of false 
positives, with big warnings to people to generally not use or make 
reports about itit unless they are already experts. So it looks like 
something pretty specific.

I also want to feel like it actually has been helpful.

But the _real_ issue is that I'm simply merging about 20+ trees per day, 
and I want to know what I merge, and I want to feel comfy about it as I 
merge it.

And kmemcheck didn't make me do that, adn I didn't feel like I had the 
time to really look at it any closer. So while I might merge it before the 
merge window is open, there's simply no way I'll merge it today (and 
almost certainly not this week, considering that I'll be on the coast for 
a long weekend).

IOW, I'm quite busy enough merging _other_ things, and handling the 
fallout from those other merges (mostly the firmware discussion ;). So I'm 
simply not interested in kmemcheck right now - I have enough to keep me 
busy.

So kmemcheck in no way made me go: "ok, we _need_ to merge this", and at 
the same time it's biggish and scary and complex enough that I felt I 
needed to take the time to think about it - which I don't feel I have 
right now.

The RCU thing, on the other hand, looked like a no-brainer from a merge 
standpoint. However, since it had merged kmemcheck, it didn't get merged 
either. I'll take a look at Ingo's second version that didn't tie the two 
together.

This is why tying things together doesn't necessarily work, and why I told 
Ingo that I'm not pulling the RCU thing just because I wasn't ready to 
pull kmemcheck.

		Linus

  reply	other threads:[~2008-07-15 20:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-14 15:20 Ingo Molnar
2008-07-15 17:38 ` Linus Torvalds
2008-07-15 19:15   ` Ingo Molnar
2008-07-15 20:14   ` Vegard Nossum
2008-07-16 17:00     ` Andi Kleen
2008-07-16 17:18       ` Vegard Nossum
2008-07-15 20:15   ` Andrew Morton
2008-07-15 20:29     ` Linus Torvalds [this message]
2008-07-15 21:01       ` Pekka Enberg
2008-07-15 23:06         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0807151319360.2867@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@us.ibm.com \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®