From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Nick Bowler <nbowler@elliptictech.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
airlied@linux.ie, eric@anholt.net,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: disable LVDS downclock by default
Date: Thu, 14 Jan 2010 23:25:57 +0200 [thread overview]
Message-ID: <84144f021001141325o4b54b5fdj84ee5d39fd8ddff3@mail.gmail.com> (raw)
In-Reply-To: <20100114124802.025bbcae@jbarnes-piketon>
Hi Jesse,
On Thu, Jan 14, 2010 at 10:48 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> Many platform support this feature, and it can provide significant
> power savings when the reduced refresh rate is low. However, on some
> platforms a secondary (reduced) timing is provided but not actually
> supported by the hardware. This results in undesirable flicker at
> runtime.
>
> So disable the feature by default, but allow users to opt-in to the
> reduced clock behavior with a new module parameter, lvds_downclock,
> that can be set to 1 to enable the feature.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> --
>
> Nick and Pekka, please try this out and reply with your Tested-by
> (assuming it works, if not I'll fix it up).
This gives me pretty much identical results as your original patch.
That is, the "shakes" are gone but I still see the occasional "flash".
Should I give Nick's patch a try to see if we're looking at the same
issue or wait for your new patch?
Pekka
next prev parent reply other threads:[~2010-01-14 21:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 5:44 Linux 2.6.33-rc4 Linus Torvalds
2010-01-13 20:21 ` Linux 2.6.33-rc4, boot regression still exists Gene Heskett
2010-01-13 21:03 ` Linux 2.6.33-rc4 Pekka Enberg
2010-01-13 21:33 ` Jesse Barnes
2010-01-13 21:50 ` Pekka Enberg
2010-01-14 0:55 ` Jesse Barnes
2010-01-14 19:15 ` Pekka Enberg
2010-01-14 19:26 ` Jesse Barnes
2010-01-14 19:31 ` Nick Bowler
2010-01-14 20:18 ` Pekka Enberg
2010-01-14 20:28 ` Nick Bowler
2010-01-14 20:48 ` [PATCH] drm/i915: disable LVDS downclock by default Jesse Barnes
2010-01-14 20:58 ` [Intel-gfx] " Peter Clifton
2010-01-14 21:05 ` Linus Torvalds
2010-01-14 21:21 ` Jesse Barnes
2010-01-14 21:16 ` Nick Bowler
2010-01-14 21:27 ` Jesse Barnes
2010-01-14 21:25 ` Pekka Enberg [this message]
2010-01-14 21:51 ` Jesse Barnes
2010-01-15 1:15 ` Nick Bowler
2010-01-15 8:54 ` Pekka Enberg
2010-01-15 16:14 ` Thomas Meyer
2010-01-15 16:21 ` Pekka Enberg
2010-01-15 16:32 ` Nick Bowler
2010-01-15 16:46 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f021001141325o4b54b5fdj84ee5d39fd8ddff3@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=airlied@linux.ie \
--cc=eric@anholt.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbowler@elliptictech.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®