From: Linus Torvalds <torvalds@linux-foundation.org>
To: Peter Clifton <pcjc2@cam.ac.uk>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Nick Bowler <nbowler@elliptictech.com>,
airlied@linux.ie, intel-gfx@lists.freedesktop.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: disable LVDS downclock by default
Date: Thu, 14 Jan 2010 13:05:17 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.1001141302360.13231@localhost.localdomain> (raw)
In-Reply-To: <1263502711.16937.5.camel@pcjc2lap>
On Thu, 14 Jan 2010, Peter Clifton wrote:
>
> Would it not be a better idea to turn this feature on by default, then
> use quirks to disable it on the afflicted borken machines?
No.
"Working" is good. "Broken" is bad.
We don't default to clearly unsafe models.
Maybe a few years from now, when people have learnt to do power management
correctly and BIOSes fill in the fields right, we can reconsider. But
right now, it's _way_ more important that things work reliably.
That said, I think a module parameter is the wrong thing. If this can be
done dynamically with a sysfs value, do it that way instead (yes, I
realize that module parameters end up being also visible in /sys, but I
think Jesse's patch doesn't allow a person to set the value - and make it
change the behavior - _while_ the display is all up and running).
Linus
next prev parent reply other threads:[~2010-01-14 21:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 5:44 Linux 2.6.33-rc4 Linus Torvalds
2010-01-13 20:21 ` Linux 2.6.33-rc4, boot regression still exists Gene Heskett
2010-01-13 21:03 ` Linux 2.6.33-rc4 Pekka Enberg
2010-01-13 21:33 ` Jesse Barnes
2010-01-13 21:50 ` Pekka Enberg
2010-01-14 0:55 ` Jesse Barnes
2010-01-14 19:15 ` Pekka Enberg
2010-01-14 19:26 ` Jesse Barnes
2010-01-14 19:31 ` Nick Bowler
2010-01-14 20:18 ` Pekka Enberg
2010-01-14 20:28 ` Nick Bowler
2010-01-14 20:48 ` [PATCH] drm/i915: disable LVDS downclock by default Jesse Barnes
2010-01-14 20:58 ` [Intel-gfx] " Peter Clifton
2010-01-14 21:05 ` Linus Torvalds [this message]
2010-01-14 21:21 ` Jesse Barnes
2010-01-14 21:16 ` Nick Bowler
2010-01-14 21:27 ` Jesse Barnes
2010-01-14 21:25 ` Pekka Enberg
2010-01-14 21:51 ` Jesse Barnes
2010-01-15 1:15 ` Nick Bowler
2010-01-15 8:54 ` Pekka Enberg
2010-01-15 16:14 ` Thomas Meyer
2010-01-15 16:21 ` Pekka Enberg
2010-01-15 16:32 ` Nick Bowler
2010-01-15 16:46 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1001141302360.13231@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=airlied@linux.ie \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nbowler@elliptictech.com \
--cc=pcjc2@cam.ac.uk \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®