From: John Ogness <john.ogness@linutronix.de>
To: Jiri Slaby <jirislaby@kernel.org>,
"Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Esben Haabendal <esben@geanix.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rengarajan S <rengarajan.s@microchip.com>,
Jeff Johnson <quic_jjohnson@quicinc.com>,
Serge Semin <fancer.lancer@gmail.com>,
Lino Sanfilippo <l.sanfilippo@kunbus.com>,
Wander Lairson Costa <wander@redhat.com>
Subject: Re: [PATCH tty-next v3 1/6] serial: 8250: Adjust the timeout for FIFO mode
Date: Mon, 02 Dec 2024 17:47:03 +0106 [thread overview]
Message-ID: <841pyqavhc.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <848cbe1c-d84d-4377-8709-bb98d1d83146@kernel.org>
On 2024-12-02, Jiri Slaby <jirislaby@kernel.org> wrote:
> I am still asking why do you want to wait for the TX machinery at the
> *end* (for the last 64 B of the 640 B line) of transmission at all? It
> occurs to me as wasted cycles.
The printk-framework has always expected that when console->write()
returns, the data has been flushed out of the hardware. I am guessing
because it is easiest to avoid possible data loss, for example, due to
suspending hardware.
If you want me to change the current behavior, I can do that in a
separate patch. I would like this patch to only be about fixing the FIFO
timeout issue.
John
next prev parent reply other threads:[~2024-12-02 16:41 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 10:57 [PATCH tty-next v3 0/6] convert 8250 to nbcon John Ogness
2024-10-25 10:57 ` [PATCH tty-next v3 1/6] serial: 8250: Adjust the timeout for FIFO mode John Ogness
2024-10-25 13:45 ` Andy Shevchenko
2024-10-25 13:51 ` Andy Shevchenko
2024-10-29 16:24 ` Wander Lairson Costa
2024-10-30 6:05 ` Jiri Slaby
2024-10-31 4:44 ` Maciej W. Rozycki
2024-10-31 8:49 ` John Ogness
2024-11-01 1:24 ` Maciej W. Rozycki
2024-11-01 8:21 ` Andy Shevchenko
2024-11-04 6:44 ` Jiri Slaby
2024-11-04 6:34 ` Jiri Slaby
2024-11-04 14:13 ` John Ogness
2024-12-02 6:12 ` Jiri Slaby
2024-12-02 16:41 ` John Ogness [this message]
2024-12-01 0:04 ` Maciej W. Rozycki
2024-10-25 10:57 ` [PATCH tty-next v3 2/6] serial: 8250: Use high-level write function for FIFO John Ogness
2024-10-25 13:50 ` Andy Shevchenko
2024-11-05 16:12 ` Petr Mladek
2024-10-25 10:57 ` [PATCH tty-next v3 3/6] serial: 8250: Split out rx stop/start code into helpers John Ogness
2024-10-25 13:55 ` Andy Shevchenko
2024-11-06 10:54 ` Petr Mladek
2024-10-25 10:57 ` [PATCH tty-next v3 4/6] serial: 8250: Specify console context for rs485_start/stop_tx John Ogness
2024-10-25 14:04 ` Andy Shevchenko
2024-10-25 14:25 ` John Ogness
2024-10-25 14:34 ` Andy Shevchenko
2024-10-30 6:13 ` Jiri Slaby
2024-10-31 9:13 ` John Ogness
2024-11-06 15:42 ` Petr Mladek
2024-11-29 17:45 ` John Ogness
2024-10-25 10:57 ` [PATCH tty-next v3 5/6] serial: 8250: Switch to nbcon console John Ogness
2024-10-25 14:22 ` Andy Shevchenko
2024-10-28 13:22 ` John Ogness
2024-11-07 9:48 ` Petr Mladek
2024-10-30 6:33 ` Jiri Slaby
2024-10-31 9:25 ` John Ogness
2024-10-25 10:57 ` [PATCH tty-next v3 6/6] serial: 8250: Revert "drop lockdep annotation from serial8250_clear_IER()" John Ogness
2024-10-25 14:05 ` Andy Shevchenko
2024-10-25 13:58 ` [PATCH tty-next v3 0/6] convert 8250 to nbcon Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=841pyqavhc.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=esben@geanix.com \
--cc=fancer.lancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=pmladek@suse.com \
--cc=quic_jjohnson@quicinc.com \
--cc=rengarajan.s@microchip.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®