mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Daniel Borkmann <daniel@iogearbox.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Kumar Kartikeya Dwivedi <memxor@gmail.com>
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v2] selftests/bpf: Use snake_case for subtest descriptions in jit_insns_arena.c
Date: Mon, 19 Oct 2026 15:18:27 +0800	[thread overview]
Message-ID: <84434f7a-1c38-03ea-3062-8e8cf364fd4e@loongson.cn> (raw)
In-Reply-To: <d13c66a3-0519-48c1-88fe-55bc755b79a2@iogearbox.net>

On 2026/10/19 下午2:47, Daniel Borkmann wrote:
> On 10/19/26 6:01 AM, Tiezhu Yang wrote:
>> Normalize two inline assembly test descriptions in jit_insns_arena.c
>> from space-separated strings to snake_case.
>>
>> It is done for consistency with other neighboring subtests registered
>> in test_jit_insns() (such as alu_imm, alu_reg, etc.). This also makes
>> it convenient to execute these subtests directly from the command line
>> without being forced to use shell quoting.
>>
>> Otherwise, unquoted shell word-splitting causes test_progs to reject
>> the extra arguments before the filter code runs:
>>
>> $ sudo ./test_progs -t jit_insns/arena access with zero offset
>> Usage: test_progs [OPTION...]
>> Try `test_progs --help' or `test_progs --usage' for more information.
>>
>> $ sudo ./test_progs -t jit_insns/cast to a user address
>> Usage: test_progs [OPTION...]
>> Try `test_progs --help' or `test_progs --usage' for more information.
>>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> Do these not work already?
> 
>    ./test_progs -t jit_insns/arena_zero_off
>    ./test_progs -t jit_insns/cast_to_user

Yes, they work.

I misunderstood that the name is "cast to a user address" in the output
rather than "cast_to_user" before, there is difference between the
description and the name.

Something like this:

$ sudo ./test_progs -t jit_insns/cast_to_user
#191/2   jit_insns/cast to a user address:OK
#191     jit_insns:OK
#192     jit_insns_blinded:OK
Summary: 2/1 PASSED, 0 SKIPPED, 0/0 FAILED

Anyway, if this patch is not necessary, please ignore it.

Thanks,
Tiezhu



  reply	other threads:[~2026-10-19  7:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19  4:01 Tiezhu Yang
2026-10-19  6:47 ` Daniel Borkmann
2026-10-19  7:18   ` Tiezhu Yang [this message]
2026-10-19  7:43     ` Daniel Borkmann
2026-10-19  7:49     ` Tiezhu Yang
2026-10-19  8:13       ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84434f7a-1c38-03ea-3062-8e8cf364fd4e@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=memxor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®