Re: [PATCH bpf-next v2] selftests/bpf: Use snake_case for subtest descriptions in jit_insns_arena.c

[Daniel Borkmann <daniel@iogearbox.net>]

On 10/19/26 9:18 AM, Tiezhu Yang wrote:
> On 2026/10/19 下午2:47, Daniel Borkmann wrote:
>> On 10/19/26 6:01 AM, Tiezhu Yang wrote:
>>> Normalize two inline assembly test descriptions in jit_insns_arena.c
>>> from space-separated strings to snake_case.
>>>
>>> It is done for consistency with other neighboring subtests registered
>>> in test_jit_insns() (such as alu_imm, alu_reg, etc.). This also makes
>>> it convenient to execute these subtests directly from the command line
>>> without being forced to use shell quoting.
>>>
>>> Otherwise, unquoted shell word-splitting causes test_progs to reject
>>> the extra arguments before the filter code runs:
>>>
>>> $ sudo ./test_progs -t jit_insns/arena access with zero offset
>>> Usage: test_progs [OPTION...]
>>> Try `test_progs --help' or `test_progs --usage' for more information.
>>>
>>> $ sudo ./test_progs -t jit_insns/cast to a user address
>>> Usage: test_progs [OPTION...]
>>> Try `test_progs --help' or `test_progs --usage' for more information.
>>>
>>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> Do these not work already?
>>
>>    ./test_progs -t jit_insns/arena_zero_off
>>    ./test_progs -t jit_insns/cast_to_user
> 
> Yes, they work.
> 
> I misunderstood that the name is "cast to a user address" in the output
> rather than "cast_to_user" before, there is difference between the
> description and the name.
> 
> Something like this:
> 
> $ sudo ./test_progs -t jit_insns/cast_to_user
> #191/2   jit_insns/cast to a user address:OK
> #191     jit_insns:OK
> #192     jit_insns_blinded:OK
> Summary: 2/1 PASSED, 0 SKIPPED, 0/0 FAILED

That makes a lot more sense as reasoning. I've applied the patch to bpf-next
and also adapted the commit message accordingly. Thanks!