From: Paolo Abeni <pabeni@redhat.com>
To: Rosen Penev <rosenp@gmail.com>, netdev@vger.kernel.org
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Jonas Gorski <jonas.gorski@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv3 net-next] net: dsa: b53: srab: propagate errors from init helpers
Date: Tue, 4 Aug 2026 13:00:26 +0200 [thread overview]
Message-ID: <845bb9f6-73e9-4301-a5ee-94e7f7aacd88@redhat.com> (raw)
In-Reply-To: <20260729202953.704662-1-rosenp@gmail.com>
On 7/29/26 10:29 PM, Rosen Penev wrote:
> -static void b53_srab_mux_init(struct platform_device *pdev)
> +static int b53_srab_mux_init(struct platform_device *pdev)
> {
> struct b53_device *dev = platform_get_drvdata(pdev);
> struct b53_srab_priv *priv = dev->priv;
> struct b53_srab_port_priv *p;
> + void __iomem *mux_config;
> unsigned int port;
> u32 reg, off = 0;
> int ret;
>
> - if (dev->pdata && dev->pdata->chip_id != BCM58XX_DEVICE_ID)
> - return;
> + if (!dev->pdata || dev->pdata->chip_id != BCM58XX_DEVICE_ID)
> + return 0;
>
> - priv->mux_config = devm_platform_ioremap_resource(pdev, 1);
> - if (IS_ERR(priv->mux_config))
> - return;
> + mux_config = devm_platform_ioremap_resource(pdev, 1);
> + if (IS_ERR(mux_config))
> + return PTR_ERR(mux_config);
Sashiko noted this strict checking may cause regression on previously
working setup:
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260729202953.704662-1-rosenp%40gmail.com
/P
next prev parent reply other threads:[~2026-08-04 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 20:29 Rosen Penev
2026-08-04 11:00 ` Paolo Abeni [this message]
2026-08-04 20:55 ` Rosen Penev
2026-08-05 7:16 ` Paolo Abeni
2026-08-05 17:59 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=845bb9f6-73e9-4301-a5ee-94e7f7aacd88@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®