* [PATCH] arm: boot: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes
@ 2017-06-27 12:15 surenderp
2017-06-27 12:27 ` Niklas Cassel
0 siblings, 1 reply; 6+ messages in thread
From: surenderp @ 2017-06-27 12:15 UTC (permalink / raw)
To: jesper.nilsson, lars.persson, niklas.cassel, robh+dt,
mark.rutland, linux
Cc: linux-arm-kernel, devicetree, linux-arm-kernel, linux-kernel,
sunil.m, Surender Polsani
From: Surender Polsani <surenderp@techveda.org>
"interrupt-parent" property is declared in root node, so it is global
to all nodes. This property is re-declared in few sub-nodes. To avoid
duplication this property is removed from following sub-nodes:
pmu, amba@0, amba@0/ethernet.
Signed-off-by: Surender Polsani <surenderp@techveda.org>
---
arch/arm/boot/dts/artpec6.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
index 767cbe8..2ed1177 100644
--- a/arch/arm/boot/dts/artpec6.dtsi
+++ b/arch/arm/boot/dts/artpec6.dtsi
@@ -151,7 +151,6 @@
interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
interrupt-affinity = <&cpu0>, <&cpu1>;
- interrupt-parent = <&intc>;
};
pcie: pcie@f8050000 {
@@ -185,7 +184,6 @@
compatible = "simple-bus";
#address-cells = <0x1>;
#size-cells = <0x1>;
- interrupt-parent = <&intc>;
ranges;
dma-ranges = <0x80000000 0x00000000 0x40000000>;
dma-coherent;
@@ -195,7 +193,6 @@
clocks = <ð_phy_ref_clk>,
<&clkctrl ARTPEC6_CLK_ETH_ACLK>;
compatible = "snps,dwc-qos-ethernet-4.10";
- interrupt-parent = <&intc>;
interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
reg = <0xf8010000 0x4000>;
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm: boot: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes
2017-06-27 12:15 [PATCH] arm: boot: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes surenderp
@ 2017-06-27 12:27 ` Niklas Cassel
2017-08-11 7:56 ` Surender Polsani
0 siblings, 1 reply; 6+ messages in thread
From: Niklas Cassel @ 2017-06-27 12:27 UTC (permalink / raw)
To: surenderp, jespern, larper, robh+dt, mark.rutland, linux
Cc: linux-arm-kernel, devicetree, linux-arm-kernel, linux-kernel, sunil.m
Acked-by: Niklas Cassel <niklas.cassel@axis.com>
On 06/27/2017 02:15 PM, surenderp@techveda.org wrote:
> From: Surender Polsani <surenderp@techveda.org>
>
> "interrupt-parent" property is declared in root node, so it is global
> to all nodes. This property is re-declared in few sub-nodes. To avoid
> duplication this property is removed from following sub-nodes:
> pmu, amba@0, amba@0/ethernet.
>
> Signed-off-by: Surender Polsani <surenderp@techveda.org>
> ---
> arch/arm/boot/dts/artpec6.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
> index 767cbe8..2ed1177 100644
> --- a/arch/arm/boot/dts/artpec6.dtsi
> +++ b/arch/arm/boot/dts/artpec6.dtsi
> @@ -151,7 +151,6 @@
> interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-affinity = <&cpu0>, <&cpu1>;
> - interrupt-parent = <&intc>;
> };
>
> pcie: pcie@f8050000 {
> @@ -185,7 +184,6 @@
> compatible = "simple-bus";
> #address-cells = <0x1>;
> #size-cells = <0x1>;
> - interrupt-parent = <&intc>;
> ranges;
> dma-ranges = <0x80000000 0x00000000 0x40000000>;
> dma-coherent;
> @@ -195,7 +193,6 @@
> clocks = <ð_phy_ref_clk>,
> <&clkctrl ARTPEC6_CLK_ETH_ACLK>;
> compatible = "snps,dwc-qos-ethernet-4.10";
> - interrupt-parent = <&intc>;
> interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
> reg = <0xf8010000 0x4000>;
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm: boot: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes
2017-06-27 12:27 ` Niklas Cassel
@ 2017-08-11 7:56 ` Surender Polsani
2017-09-04 15:23 ` Niklas Cassel
0 siblings, 1 reply; 6+ messages in thread
From: Surender Polsani @ 2017-08-11 7:56 UTC (permalink / raw)
To: Niklas Cassel, jespern, larper, robh+dt, mark.rutland, linux
Cc: linux-arm-kernel, devicetree, linux-arm-kernel, linux-kernel, sunil.m
On Tuesday 27 June 2017 05:57 PM, Niklas Cassel wrote:
> Acked-by: Niklas Cassel <niklas.cassel@axis.com>
Hi Nik, This patch has been Acknowledged but is not getting added /
applied to the
respective git source tree. Please let me know if there is any problem.
Thanks
Surender
>
> On 06/27/2017 02:15 PM, surenderp@techveda.org wrote:
>> From: Surender Polsani <surenderp@techveda.org>
>>
>> "interrupt-parent" property is declared in root node, so it is global
>> to all nodes. This property is re-declared in few sub-nodes. To avoid
>> duplication this property is removed from following sub-nodes:
>> pmu, amba@0, amba@0/ethernet.
>>
>> Signed-off-by: Surender Polsani <surenderp@techveda.org>
>> ---
>> arch/arm/boot/dts/artpec6.dtsi | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
>> index 767cbe8..2ed1177 100644
>> --- a/arch/arm/boot/dts/artpec6.dtsi
>> +++ b/arch/arm/boot/dts/artpec6.dtsi
>> @@ -151,7 +151,6 @@
>> interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
>> <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
>> interrupt-affinity = <&cpu0>, <&cpu1>;
>> - interrupt-parent = <&intc>;
>> };
>>
>> pcie: pcie@f8050000 {
>> @@ -185,7 +184,6 @@
>> compatible = "simple-bus";
>> #address-cells = <0x1>;
>> #size-cells = <0x1>;
>> - interrupt-parent = <&intc>;
>> ranges;
>> dma-ranges = <0x80000000 0x00000000 0x40000000>;
>> dma-coherent;
>> @@ -195,7 +193,6 @@
>> clocks = <ð_phy_ref_clk>,
>> <&clkctrl ARTPEC6_CLK_ETH_ACLK>;
>> compatible = "snps,dwc-qos-ethernet-4.10";
>> - interrupt-parent = <&intc>;
>> interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
>> reg = <0xf8010000 0x4000>;
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm: boot: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes
2017-08-11 7:56 ` Surender Polsani
@ 2017-09-04 15:23 ` Niklas Cassel
2017-09-06 5:08 ` [PATCH v2] arm: " surenderp
2017-10-19 21:25 ` [PATCH] arm: boot: " Arnd Bergmann
0 siblings, 2 replies; 6+ messages in thread
From: Niklas Cassel @ 2017-09-04 15:23 UTC (permalink / raw)
To: Surender Polsani, jespern, larper, robh+dt, mark.rutland, linux
Cc: linux-arm-kernel, devicetree, linux-arm-kernel, linux-kernel, sunil.m
On 08/11/2017 09:56 AM, Surender Polsani wrote:
> On Tuesday 27 June 2017 05:57 PM, Niklas Cassel wrote:
>> Acked-by: Niklas Cassel <niklas.cassel@axis.com>
>
> Hi Nik, This patch has been Acknowledged but is not getting added / applied to the
> respective git source tree. Please let me know if there is any problem.
Hello Surender,
Sorry for the delay.
Could you please resend your patch,
add "To: arm@kernel.org", together with my Ack.
Best regards,
Niklas
>
> Thanks
> Surender
>>
>> On 06/27/2017 02:15 PM, surenderp@techveda.org wrote:
>>> From: Surender Polsani <surenderp@techveda.org>
>>>
>>> "interrupt-parent" property is declared in root node, so it is global
>>> to all nodes. This property is re-declared in few sub-nodes. To avoid
>>> duplication this property is removed from following sub-nodes:
>>> pmu, amba@0, amba@0/ethernet.
>>>
>>> Signed-off-by: Surender Polsani <surenderp@techveda.org>
>>> ---
>>> arch/arm/boot/dts/artpec6.dtsi | 3 ---
>>> 1 file changed, 3 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
>>> index 767cbe8..2ed1177 100644
>>> --- a/arch/arm/boot/dts/artpec6.dtsi
>>> +++ b/arch/arm/boot/dts/artpec6.dtsi
>>> @@ -151,7 +151,6 @@
>>> interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
>>> <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
>>> interrupt-affinity = <&cpu0>, <&cpu1>;
>>> - interrupt-parent = <&intc>;
>>> };
>>> pcie: pcie@f8050000 {
>>> @@ -185,7 +184,6 @@
>>> compatible = "simple-bus";
>>> #address-cells = <0x1>;
>>> #size-cells = <0x1>;
>>> - interrupt-parent = <&intc>;
>>> ranges;
>>> dma-ranges = <0x80000000 0x00000000 0x40000000>;
>>> dma-coherent;
>>> @@ -195,7 +193,6 @@
>>> clocks = <ð_phy_ref_clk>,
>>> <&clkctrl ARTPEC6_CLK_ETH_ACLK>;
>>> compatible = "snps,dwc-qos-ethernet-4.10";
>>> - interrupt-parent = <&intc>;
>>> interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
>>> reg = <0xf8010000 0x4000>;
>>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] arm: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes
2017-09-04 15:23 ` Niklas Cassel
@ 2017-09-06 5:08 ` surenderp
2017-10-19 21:25 ` [PATCH] arm: boot: " Arnd Bergmann
1 sibling, 0 replies; 6+ messages in thread
From: surenderp @ 2017-09-06 5:08 UTC (permalink / raw)
To: jesper.nilsson, lars.persson, niklas.cassel, robh+dt,
mark.rutland, linux, arm
Cc: sunil.m, linux-arm-kernel, devicetree, linux-arm-kernel,
linux-kernel, Surender Polsani
From: Surender Polsani <surenderp@techveda.org>
"interrupt-parent" property is declared in root node, so it is global
to all nodes. This property is re-declared in few sub-nodes. To avoid
duplication this property is removed from following sub-nodes: pmu,
amba@0, amba@0/ethernet.
Signed-off-by: Surender Polsani <surenderp@techveda.org>
Acked-by: Niklas Cassel <niklas.cassel@axis.com>
---
Changes for v2:
- Done few changes as suggested by Niklas Cassel.
- Patch is rebased and built(ARCH=arm) on latest next-20170905.
---
arch/arm/boot/dts/artpec6.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
index 767cbe8..2ed1177 100644
--- a/arch/arm/boot/dts/artpec6.dtsi
+++ b/arch/arm/boot/dts/artpec6.dtsi
@@ -151,7 +151,6 @@
interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
interrupt-affinity = <&cpu0>, <&cpu1>;
- interrupt-parent = <&intc>;
};
pcie: pcie@f8050000 {
@@ -185,7 +184,6 @@
compatible = "simple-bus";
#address-cells = <0x1>;
#size-cells = <0x1>;
- interrupt-parent = <&intc>;
ranges;
dma-ranges = <0x80000000 0x00000000 0x40000000>;
dma-coherent;
@@ -195,7 +193,6 @@
clocks = <ð_phy_ref_clk>,
<&clkctrl ARTPEC6_CLK_ETH_ACLK>;
compatible = "snps,dwc-qos-ethernet-4.10";
- interrupt-parent = <&intc>;
interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
reg = <0xf8010000 0x4000>;
--
1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm: boot: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes
2017-09-04 15:23 ` Niklas Cassel
2017-09-06 5:08 ` [PATCH v2] arm: " surenderp
@ 2017-10-19 21:25 ` Arnd Bergmann
1 sibling, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2017-10-19 21:25 UTC (permalink / raw)
To: Niklas Cassel
Cc: Surender Polsani, jespern, larper, Rob Herring, Mark Rutland,
Russell King - ARM Linux, linux-arm-kernel, DTML, Linux ARM,
Linux Kernel Mailing List, sunil.m
On Mon, Sep 4, 2017 at 5:23 PM, Niklas Cassel <niklas.cassel@axis.com> wrote:
> On 08/11/2017 09:56 AM, Surender Polsani wrote:
>> On Tuesday 27 June 2017 05:57 PM, Niklas Cassel wrote:
>>> Acked-by: Niklas Cassel <niklas.cassel@axis.com>
>>
>> Hi Nik, This patch has been Acknowledged but is not getting added / applied to the
>> respective git source tree. Please let me know if there is any problem.
>
> Hello Surender,
>
> Sorry for the delay.
>
> Could you please resend your patch,
> add "To: arm@kernel.org", together with my Ack.
I stumbled over this old patch and have applied it to next/dt now with your Ack,
since I did not see another copy sent to arm@kernel.org.
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-19 21:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-27 12:15 [PATCH] arm: boot: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes surenderp
2017-06-27 12:27 ` Niklas Cassel
2017-08-11 7:56 ` Surender Polsani
2017-09-04 15:23 ` Niklas Cassel
2017-09-06 5:08 ` [PATCH v2] arm: " surenderp
2017-10-19 21:25 ` [PATCH] arm: boot: " Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®