* [PATCH RESEND] mt76: mt7915: check devm_kasprintf() returned value
@ 2024-09-03 1:49 Ma Ke
2024-09-04 8:59 ` Matthias Brugger
0 siblings, 1 reply; 2+ messages in thread
From: Ma Ke @ 2024-09-03 1:49 UTC (permalink / raw)
To: nbd, lorenzo, ryder.lee, shayne.chen, sean.wang, kvalo,
matthias.bgg, angelogioacchino.delregno, johannes.berg,
ruanjinjie, make24, howard-yh.hsu, chui-hao.chiu, greearb, akpm
Cc: linux-wireless, linux-kernel, linux-arm-kernel, linux-mediatek, stable
devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.
Found by code review.
Cc: stable@vger.kernel.org
Fixes: 6ae39b7c7ed4 ("wifi: mt76: mt7921: Support temp sensor")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
drivers/net/wireless/mediatek/mt76/mt7915/init.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
index a978f434dc5e..7bc3b4cd3592 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
@@ -194,6 +194,8 @@ static int mt7915_thermal_init(struct mt7915_phy *phy)
name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7915_%s",
wiphy_name(wiphy));
+ if (!name)
+ return -ENOMEM;
cdev = thermal_cooling_device_register(name, phy, &mt7915_thermal_ops);
if (!IS_ERR(cdev)) {
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] mt76: mt7915: check devm_kasprintf() returned value
2024-09-03 1:49 [PATCH RESEND] mt76: mt7915: check devm_kasprintf() returned value Ma Ke
@ 2024-09-04 8:59 ` Matthias Brugger
0 siblings, 0 replies; 2+ messages in thread
From: Matthias Brugger @ 2024-09-04 8:59 UTC (permalink / raw)
To: Ma Ke, nbd, lorenzo, ryder.lee, shayne.chen, sean.wang, kvalo,
angelogioacchino.delregno, johannes.berg, ruanjinjie,
howard-yh.hsu, chui-hao.chiu, greearb, akpm
Cc: linux-wireless, linux-kernel, linux-arm-kernel, linux-mediatek, stable
On 03/09/2024 03:49, Ma Ke wrote:
> devm_kasprintf() can return a NULL pointer on failure but this returned
> value is not checked. Fix this lack and check the returned value.
>
> Found by code review.
>
> Cc: stable@vger.kernel.org
> Fixes: 6ae39b7c7ed4 ("wifi: mt76: mt7921: Support temp sensor")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt7915/init.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> index a978f434dc5e..7bc3b4cd3592 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> @@ -194,6 +194,8 @@ static int mt7915_thermal_init(struct mt7915_phy *phy)
>
> name = devm_kasprintf(&wiphy->dev, GFP_KERNEL, "mt7915_%s",
> wiphy_name(wiphy));
> + if (!name)
> + return -ENOMEM;
>
> cdev = thermal_cooling_device_register(name, phy, &mt7915_thermal_ops);
> if (!IS_ERR(cdev)) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-04 8:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-03 1:49 [PATCH RESEND] mt76: mt7915: check devm_kasprintf() returned value Ma Ke
2024-09-04 8:59 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®