mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: Juergen Gross <jgross@suse.com>, Ingo Molnar <mingo@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <x86@kernel.org>, <hpa@zytor.com>,
	<tglx@linutronix.de>, <mingo@redhat.com>, <arnd@arndb.de>,
	<peterz@infradead.org>
Subject: Re: [PATCH] paravirt/locks: avoid modifying static key before jump_label_init()
Date: Fri, 27 Oct 2017 17:38:24 +0800	[thread overview]
Message-ID: <84cfd68e-a891-5a54-174e-4bd215d932d6@cn.fujitsu.com> (raw)
In-Reply-To: <187967ca-a700-b770-90fe-ae8cd294b0d1@suse.com>

Hi Juergen

At 10/27/2017 05:21 PM, Juergen Gross wrote:
> On 27/10/17 10:43, Ingo Molnar wrote:
>>
>> * Juergen Gross <jgross@suse.com> wrote:
>>
>>> Don't try to set the static virt_spin_lock_key to a value before
>>> jump_label_init() has been called, as this will result in a WARN().
>>>
>>> Solve the problem by introducing a new lock_init() hook called after
>>> jump_label_init() instead of doing the call inside of
>>> smp_prepare_boot_cpu().
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>> ---
>>> Based on kernel/git/tip/tip.git locking/core
>>
>> Just a quick ping: what's the conclusion of the discussion, do we want this patch
>> as-is?
>
> Dou Liyang (CC-ed) suggested another alternative he wanted to test. This
> would be much less intrusive. I can send a patch based on his idea in
> case he doesn't react in time: he basically suggested moving the call of

I am sorry I misunderstood your comments, I thought you were going to 
send a new version, So I said i will test it. ;-)

Now, I understood clearly. I will do it and send a patch for this bug.

Thanks,
	dou

      reply	other threads:[~2017-10-27  9:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 13:49 Juergen Gross
2017-10-25  4:26 ` Dou Liyang
2017-10-25  6:58   ` Juergen Gross
2017-10-25  7:35     ` Dou Liyang
2017-10-25  7:51       ` Juergen Gross
2017-10-25  8:06         ` Dou Liyang
2017-10-27  8:43 ` Ingo Molnar
2017-10-27  9:21   ` Juergen Gross
2017-10-27  9:38     ` Dou Liyang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84cfd68e-a891-5a54-174e-4bd215d932d6@cn.fujitsu.com \
    --to=douly.fnst@cn.fujitsu.com \
    --cc=arnd@arndb.de \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®