mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Juergen Gross <jgross@suse.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com,
	tglx@linutronix.de, mingo@redhat.com, arnd@arndb.de,
	peterz@infradead.org
Subject: Re: [PATCH] paravirt/locks: avoid modifying static key before jump_label_init()
Date: Fri, 27 Oct 2017 10:43:12 +0200	[thread overview]
Message-ID: <20171027084312.k2ay4pfh6h3ajatn@gmail.com> (raw)
In-Reply-To: <20171023134948.24886-1-jgross@suse.com>


* Juergen Gross <jgross@suse.com> wrote:

> Don't try to set the static virt_spin_lock_key to a value before
> jump_label_init() has been called, as this will result in a WARN().
> 
> Solve the problem by introducing a new lock_init() hook called after
> jump_label_init() instead of doing the call inside of
> smp_prepare_boot_cpu().
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> Based on kernel/git/tip/tip.git locking/core

Just a quick ping: what's the conclusion of the discussion, do we want this patch 
as-is?

Also, it's unclear from the changelog under what circumstances this bug was 
observed and what symptoms there are and how severe the bug - can the warning 
trigger on vanilla v4.14?

Thanks,

	Ingo

  parent reply	other threads:[~2017-10-27  8:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 13:49 Juergen Gross
2017-10-25  4:26 ` Dou Liyang
2017-10-25  6:58   ` Juergen Gross
2017-10-25  7:35     ` Dou Liyang
2017-10-25  7:51       ` Juergen Gross
2017-10-25  8:06         ` Dou Liyang
2017-10-27  8:43 ` Ingo Molnar [this message]
2017-10-27  9:21   ` Juergen Gross
2017-10-27  9:38     ` Dou Liyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171027084312.k2ay4pfh6h3ajatn@gmail.com \
    --to=mingo@kernel.org \
    --cc=arnd@arndb.de \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®