* [PATCH] block: fix comment for op_is_zone_mgmt() to include RESET_ALL
@ 2025-12-03 15:17 shechenglong
2025-12-04 7:02 ` Johannes Thumshirn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: shechenglong @ 2025-12-03 15:17 UTC (permalink / raw)
To: axboe; +Cc: linux-block, linux-kernel, stone.xulei, chenjialong, shechenglong
REQ_OP_ZONE_RESET_ALL is a zone management request, and op_is_zone_mgmt()
has returned true for it.
Update the comment to remove the misleading exception note so
the documentation matches the implementation.
Fixes: 12a1c93 ("block: fix op_is_zone_mgmt() to handle REQ_OP_ZONE_RESET_ALL")
Signed-off-by: shechenglong <shechenglong@xfusion.com>
---
include/linux/blk_types.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index 44c30183ecc3..4e2e3aed32f5 100644
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -469,10 +469,7 @@ static inline bool op_is_discard(blk_opf_t op)
}
/*
- * Check if a bio or request operation is a zone management operation, with
- * the exception of REQ_OP_ZONE_RESET_ALL which is treated as a special case
- * due to its different handling in the block layer and device response in
- * case of command failure.
+ * Check if a bio or request operation is a zone management operation.
*/
static inline bool op_is_zone_mgmt(enum req_op op)
{
--
2.33.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] block: fix comment for op_is_zone_mgmt() to include RESET_ALL
2025-12-03 15:17 [PATCH] block: fix comment for op_is_zone_mgmt() to include RESET_ALL shechenglong
@ 2025-12-04 7:02 ` Johannes Thumshirn
2025-12-04 7:40 ` Damien Le Moal
2025-12-04 14:25 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Johannes Thumshirn @ 2025-12-04 7:02 UTC (permalink / raw)
To: shechenglong, axboe; +Cc: linux-block, linux-kernel, stone.xulei, chenjialong
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] block: fix comment for op_is_zone_mgmt() to include RESET_ALL
2025-12-03 15:17 [PATCH] block: fix comment for op_is_zone_mgmt() to include RESET_ALL shechenglong
2025-12-04 7:02 ` Johannes Thumshirn
@ 2025-12-04 7:40 ` Damien Le Moal
2025-12-04 14:25 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2025-12-04 7:40 UTC (permalink / raw)
To: shechenglong, axboe; +Cc: linux-block, linux-kernel, stone.xulei, chenjialong
On 12/4/25 00:17, shechenglong wrote:
> REQ_OP_ZONE_RESET_ALL is a zone management request, and op_is_zone_mgmt()
> has returned true for it.
>
> Update the comment to remove the misleading exception note so
> the documentation matches the implementation.
>
> Fixes: 12a1c93 ("block: fix op_is_zone_mgmt() to handle REQ_OP_ZONE_RESET_ALL")
> Signed-off-by: shechenglong <shechenglong@xfusion.com>
Looks good.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] block: fix comment for op_is_zone_mgmt() to include RESET_ALL
2025-12-03 15:17 [PATCH] block: fix comment for op_is_zone_mgmt() to include RESET_ALL shechenglong
2025-12-04 7:02 ` Johannes Thumshirn
2025-12-04 7:40 ` Damien Le Moal
@ 2025-12-04 14:25 ` Jens Axboe
2 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2025-12-04 14:25 UTC (permalink / raw)
To: shechenglong; +Cc: linux-block, linux-kernel, stone.xulei, chenjialong
On Wed, 03 Dec 2025 23:17:49 +0800, shechenglong wrote:
> REQ_OP_ZONE_RESET_ALL is a zone management request, and op_is_zone_mgmt()
> has returned true for it.
>
> Update the comment to remove the misleading exception note so
> the documentation matches the implementation.
>
>
> [...]
Applied, thanks!
[1/1] block: fix comment for op_is_zone_mgmt() to include RESET_ALL
commit: 4ce1aeacddb06241a1a9c75bf1c1bc3be5a799dd
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-04 14:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-03 15:17 [PATCH] block: fix comment for op_is_zone_mgmt() to include RESET_ALL shechenglong
2025-12-04 7:02 ` Johannes Thumshirn
2025-12-04 7:40 ` Damien Le Moal
2025-12-04 14:25 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®