mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Luca Weiss <luca@lucaweiss.eu>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jens Reidel <adrian@mainlining.org>, Bhushan Shah <bshah@kde.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: msm8974-hammerhead: Update model property
Date: Mon, 8 Dec 2025 16:26:45 +0100	[thread overview]
Message-ID: <8510a763-adfa-4f9c-9502-ca4787dd25a1@oss.qualcomm.com> (raw)
In-Reply-To: <20251208-msm8974-hammerhead-model-v1-1-88975f30cbaa@lucaweiss.eu>

On 12/8/25 1:41 PM, Luca Weiss wrote:
> Many years have passed (more than 9 actually) since the introduction of
> the Nexus 5 dts to Linux and it's high time to update the model property
> to be a proper model name and thereby bringing it to the standards of
> the 2020s.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
> The phone was manufactured by LG and sold by Google. Some sources call
> it LG Nexus 5, some Google Nexus 5. I think it was mostly marketed as
> just Nexus 5, but consensus in upstream dts seems to be to use the
> manufacturer, see Nexus 5X, Nexus 6P, Nexus 4.
> 
> Arguments could also easily be made to change the compatible to
> "lg,hammerhead" and rename the dts, since lge (LG Electronics) is not
> even documented in vendor-prefixes and doesn't really appear anywhere
> else in the kernel and lg, (for LG Corporation, the parent of LG
> Electronics from what I can tell) is used. But that's more invasive so
> I'm leaving this out in favor of this simple patch.
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

  parent reply	other threads:[~2025-12-08 15:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08 12:41 Luca Weiss
2025-12-08 13:32 ` David Heidelberg
2025-12-08 15:26 ` Konrad Dybcio [this message]
2026-01-05 14:07 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8510a763-adfa-4f9c-9502-ca4787dd25a1@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=adrian@mainlining.org \
    --cc=andersson@kernel.org \
    --cc=bshah@kde.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@lucaweiss.eu \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®