mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: qcom: msm8974-hammerhead: Update model property
@ 2025-12-08 12:41 Luca Weiss
  2025-12-08 13:32 ` David Heidelberg
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Luca Weiss @ 2025-12-08 12:41 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Jens Reidel, Bhushan Shah
  Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
	devicetree, linux-kernel, Luca Weiss

Many years have passed (more than 9 actually) since the introduction of
the Nexus 5 dts to Linux and it's high time to update the model property
to be a proper model name and thereby bringing it to the standards of
the 2020s.

Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
---
The phone was manufactured by LG and sold by Google. Some sources call
it LG Nexus 5, some Google Nexus 5. I think it was mostly marketed as
just Nexus 5, but consensus in upstream dts seems to be to use the
manufacturer, see Nexus 5X, Nexus 6P, Nexus 4.

Arguments could also easily be made to change the compatible to
"lg,hammerhead" and rename the dts, since lge (LG Electronics) is not
even documented in vendor-prefixes and doesn't really appear anywhere
else in the kernel and lg, (for LG Corporation, the parent of LG
Electronics from what I can tell) is used. But that's more invasive so
I'm leaving this out in favor of this simple patch.
---
 arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
index b3127f0383cf..8f4a1fda9276 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
+++ b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
@@ -7,7 +7,7 @@
 #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
 
 / {
-	model = "LGE MSM 8974 HAMMERHEAD";
+	model = "LG Nexus 5";
 	compatible = "lge,hammerhead", "qcom,msm8974";
 	chassis-type = "handset";
 

---
base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449
change-id: 20251208-msm8974-hammerhead-model-fa3aca1fda0e

Best regards,
-- 
Luca Weiss <luca@lucaweiss.eu>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: qcom: msm8974-hammerhead: Update model property
  2025-12-08 12:41 [PATCH] ARM: dts: qcom: msm8974-hammerhead: Update model property Luca Weiss
@ 2025-12-08 13:32 ` David Heidelberg
  2025-12-08 15:26 ` Konrad Dybcio
  2026-01-05 14:07 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: David Heidelberg @ 2025-12-08 13:32 UTC (permalink / raw)
  To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Jens Reidel, Bhushan Shah
  Cc: phone-devel, linux-arm-msm, devicetree, linux-kernel

On 08/12/2025 13:41, Luca Weiss wrote:
> Many years have passed (more than 9 actually) since the introduction of
> the Nexus 5 dts to Linux and it's high time to update the model property
> to be a proper model name and thereby bringing it to the standards of
> the 2020s.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
> The phone was manufactured by LG and sold by Google. Some sources call
> it LG Nexus 5, some Google Nexus 5. I think it was mostly marketed as
> just Nexus 5, but consensus in upstream dts seems to be to use the
> manufacturer, see Nexus 5X, Nexus 6P, Nexus 4.
> 
> Arguments could also easily be made to change the compatible to
> "lg,hammerhead" and rename the dts, since lge (LG Electronics) is not
> even documented in vendor-prefixes and doesn't really appear anywhere
> else in the kernel and lg, (for LG Corporation, the parent of LG
> Electronics from what I can tell) is used. But that's more invasive so
> I'm leaving this out in favor of this simple patch.
> ---
>   arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
> index b3127f0383cf..8f4a1fda9276 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974-lge-nexus5-hammerhead.dts
> @@ -7,7 +7,7 @@
>   #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>   
>   / {
> -	model = "LGE MSM 8974 HAMMERHEAD";
> +	model = "LG Nexus 5";
>   	compatible = "lge,hammerhead", "qcom,msm8974";
>   	chassis-type = "handset";
>   
> 
> ---
> base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449
> change-id: 20251208-msm8974-hammerhead-model-fa3aca1fda0e
> 
> Best regards,

Hehe, definitely an improvement.

Reviewed-by: David Heidelberg <david@ixit.cz>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: qcom: msm8974-hammerhead: Update model property
  2025-12-08 12:41 [PATCH] ARM: dts: qcom: msm8974-hammerhead: Update model property Luca Weiss
  2025-12-08 13:32 ` David Heidelberg
@ 2025-12-08 15:26 ` Konrad Dybcio
  2026-01-05 14:07 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2025-12-08 15:26 UTC (permalink / raw)
  To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Jens Reidel, Bhushan Shah
  Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
	devicetree, linux-kernel

On 12/8/25 1:41 PM, Luca Weiss wrote:
> Many years have passed (more than 9 actually) since the introduction of
> the Nexus 5 dts to Linux and it's high time to update the model property
> to be a proper model name and thereby bringing it to the standards of
> the 2020s.
> 
> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
> ---
> The phone was manufactured by LG and sold by Google. Some sources call
> it LG Nexus 5, some Google Nexus 5. I think it was mostly marketed as
> just Nexus 5, but consensus in upstream dts seems to be to use the
> manufacturer, see Nexus 5X, Nexus 6P, Nexus 4.
> 
> Arguments could also easily be made to change the compatible to
> "lg,hammerhead" and rename the dts, since lge (LG Electronics) is not
> even documented in vendor-prefixes and doesn't really appear anywhere
> else in the kernel and lg, (for LG Corporation, the parent of LG
> Electronics from what I can tell) is used. But that's more invasive so
> I'm leaving this out in favor of this simple patch.
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: qcom: msm8974-hammerhead: Update model property
  2025-12-08 12:41 [PATCH] ARM: dts: qcom: msm8974-hammerhead: Update model property Luca Weiss
  2025-12-08 13:32 ` David Heidelberg
  2025-12-08 15:26 ` Konrad Dybcio
@ 2026-01-05 14:07 ` Bjorn Andersson
  2 siblings, 0 replies; 4+ messages in thread
From: Bjorn Andersson @ 2026-01-05 14:07 UTC (permalink / raw)
  To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Jens Reidel, Bhushan Shah, Luca Weiss
  Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm,
	devicetree, linux-kernel


On Mon, 08 Dec 2025 21:41:02 +0900, Luca Weiss wrote:
> Many years have passed (more than 9 actually) since the introduction of
> the Nexus 5 dts to Linux and it's high time to update the model property
> to be a proper model name and thereby bringing it to the standards of
> the 2020s.
> 
> 

Applied, thanks!

[1/1] ARM: dts: qcom: msm8974-hammerhead: Update model property
      commit: e5e22c8ea49e62c390e3843a632727569f6470a2

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-01-05 14:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-08 12:41 [PATCH] ARM: dts: qcom: msm8974-hammerhead: Update model property Luca Weiss
2025-12-08 13:32 ` David Heidelberg
2025-12-08 15:26 ` Konrad Dybcio
2026-01-05 14:07 ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®