From: Denis Benato <denis.benato@linux.dev>
To: Andrei Rusu de Castro <arc@empyreal.works>
Cc: "Corentin Chary" <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: asus-wmi: write the thermal policy only when it changes
Date: Thu, 12 Nov 2026 21:33:54 +0100 [thread overview]
Message-ID: <8523039e-ba83-48f3-aec4-6d9540b9d0fe@linux.dev> (raw)
In-Reply-To: <20261112-asus-wmi-tpolicy-reply-f7889fb1@empyreal.works>
12 nov 2026 21:27:45 Andrei Rusu de Castro <arc@empyreal.works>:
> On Thu, 12 Nov 2026 09:32:21 +0100, Denis Benato wrote:
>> I don't agree with this: if the userspace requests a power profile
>> change the driver must honor that request.
>
> Hi Denis,
>
> Thanks for the review and the explanation, that makes sense. On my
> machine the package power limits are set outside asus-armoury, so the
> re-apply you suggest would not cover them, and I'll keep this change as
> a local patch instead of pursuing it here.
How are you applying limits? The only thing that comes to mind is intel rapl, but it has way lower limits than what asus validated.
>
> Thanks,
> Andrei
next prev parent reply other threads:[~2026-11-12 20:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 21:43 Andrei Rusu de Castro
2026-11-12 8:32 ` Denis Benato
2026-11-12 20:27 ` Andrei Rusu de Castro
2026-11-12 20:33 ` Denis Benato [this message]
2026-11-12 21:04 ` Andrei Rusu de Castro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8523039e-ba83-48f3-aec4-6d9540b9d0fe@linux.dev \
--to=denis.benato@linux.dev \
--cc=arc@empyreal.works \
--cc=corentin.chary@gmail.com \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®