mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Andreas Hindborg <a.hindborg@kernel.org>,
	Bart Van Assche <bvanassche@acm.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: fix arg type in `blk_mq_update_nr_hw_queues`
Date: Tue, 9 Jun 2026 09:05:29 -0600	[thread overview]
Message-ID: <8572a148-3b73-4de0-ac98-74b66e3d7ffe@kernel.dk> (raw)
In-Reply-To: <87qzmggn43.fsf@kernel.org>

On 6/9/26 1:59 AM, Andreas Hindborg wrote:
>> If this patch does not change the behavior of the code for any practical
>> use case that would be good to mention.
> 
> The patch does not change behavior of the code as long as no overflows
> occur, and they are not likely to occur. I will be sure to add that to
> the commit message.
> 
> I came across this while designing the Rust API for these functions.
> Rust is kind of particular about integer types, so it gave me some
> checks/casts on the Rust side that really should no be required. I was
> thinking we might as well change the type on the C side to unsigned when
> the data it carries really should be unsigned.

The change itself is fine imho, but I agree with Bart that the commit
messages should be phrased very differently. It's not a fix, it's a
cleanup that makes your life simpler on the rust side.

-- 
Jens Axboe

      reply	other threads:[~2026-06-09 15:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08  8:39 Andreas Hindborg
2026-06-08 15:50 ` Bart Van Assche
2026-06-09  7:59   ` Andreas Hindborg
2026-06-09 15:05     ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8572a148-3b73-4de0-ac98-74b66e3d7ffe@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=a.hindborg@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®