From: Rong Zhang <i@rong.moe>
To: "Devin Bayer" <dev@doubly.so>,
"Denis Benato" <denis.benato@linux.dev>,
skyedryv <skyedryv@gmail.com>,
git@turtledev.nz, "Corentin Chary" <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
platform-driver-x86@vger.kernel.org
Cc: "José Guilherme de Castro Rodrigues"
<jose.guilherme.cr.bh@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] platform/x86: asus-wmi: fix camera key LED on Zenbook S14
Date: Thu, 19 Nov 2026 22:33:21 +0800 [thread overview]
Message-ID: <85a6f4cf8b9a1409d343705886afe935952fdf62.camel@rong.moe> (raw)
In-Reply-To: <b4d1f79d-770a-4e28-86cb-c3a5fd9187f6@doubly.so>
Hi Devin,
Thanks for your information.
On Thu, 2026-11-19 at 14:57 +0100, Devin Bayer wrote:
>
> On 19/11/2026 14.12, Rong Zhang wrote:
> > > I don't know about query and notifications.
> >
> > Could you test if any event is emitted when you press the camera key? See
> > is_camera_toggle() in Zane's patch for the corresponding event codes.
>
> Is this what you are looking for?
>
> bpftrace -e '
> kprobe:asus_wmi:asus_wmi_notify {
> $obj = (union acpi_object *)arg0;
> printf("_WED type=%u value=0x%016llx\n",
> $obj->type, $obj->integer.value);
> }'
>
> When I press the camera key, doesn't matter if it's disabled (LED on) or
> disabled (LED off):
>
> Attached 1 probe
> _WED type=1 value=0x0000000000000085
> _WED type=1 value=0x0000000000000085
>
This is exactly what I am looking for! Your device can take the advantage
of brightness_hw_changed though CAMERA_NEG, which proves the viability of
my proposal.
>
> > > The hardware key doesn't do anything if it's remapped, at least in my setup.
> >
> > How to "remap" the "hardware key"? Isn't the LED device only "remaps" the
> > status LED?
>
> I mean the hardware key does nothing - it doesn't control the LED or
> camera.
>
Got it. This is also what I expect. I misinterpreted your word as
remapping the key though hardware (i.e., EC).
Thanks,
Rong
> The desktop keyboard key is remapped in software so the desktop
> doesn't disable the camera when it's pressed.
>
> Cheers,
> Devin
next prev parent reply other threads:[~2026-11-19 14:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-19 6:35 Zane Hunt via B4 Relay
2026-10-19 8:38 ` Ilpo Järvinen
2026-10-21 1:09 ` José Guilherme de Castro Rodrigues
2026-10-21 12:34 ` Rong Zhang
2026-11-16 12:48 ` Rong Zhang
2026-11-17 1:09 ` Denis Benato
2026-11-17 13:52 ` Rong Zhang
2026-11-18 9:02 ` Devin Bayer
2026-11-19 13:12 ` Rong Zhang
2026-11-19 13:57 ` Devin Bayer
2026-11-19 14:33 ` Rong Zhang [this message]
2026-11-15 11:55 skyedryv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85a6f4cf8b9a1409d343705886afe935952fdf62.camel@rong.moe \
--to=i@rong.moe \
--cc=corentin.chary@gmail.com \
--cc=denis.benato@linux.dev \
--cc=dev@doubly.so \
--cc=git@turtledev.nz \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jose.guilherme.cr.bh@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=skyedryv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®