From: Andrew Lunn <andrew@lunn.ch>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>
Cc: "Marek Behún" <kabel@kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Richard Cochran" <richardcochran@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
paul.arola@telus.com, scott.roberts@telus.com
Subject: Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: enable support for 88E6361 switch
Date: Fri, 19 May 2023 15:30:28 +0200 [thread overview]
Message-ID: <85c07e51-8a0b-4328-bab3-acad2ee104e1@lunn.ch> (raw)
In-Reply-To: <7419ffc0-b292-97c4-fee6-610a1a841265@bootlin.com>
> >> Ports 1 and 2 should hopefully be protected by the
> >> invalid_port_mask. It should not even be possible to create those
> >> ports. port 0 is interesting, and possibly currently broken on
> >> 6393. Please take a look at that.
> >
> > Why would port 0 be broken on 6393x ?
> By "broken", I guess Andrew means that if we feed port 0 to
> mv88e6xxx_phy_is_internal, it will return true, which is wrong since there is no
> internal phy for port 0 on 6393X ?
Yes, that is what i was thinking. But i did not spend the time to look
at the code see if this is actually true. There might be a special
case somewhere in the code.
But in general, we try to avoid special cases, and add device specific
ops.
Andrew
next prev parent reply other threads:[~2023-05-19 13:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 20:34 [PATCH net-next 0/2] net: dsa: mv88e6xxx: add 88E6361 support alexis.lothore
2023-05-17 20:34 ` [PATCH net-next 1/2] dt-bindings: net: dsa: marvell: add MV88E6361 switch to compatibility list alexis.lothore
2023-05-17 20:39 ` Andrew Lunn
2023-05-18 21:43 ` Conor Dooley
2023-08-24 18:49 ` airat.gl
2023-08-24 22:11 ` Andrew Lunn
2023-08-25 8:21 ` Alexis Lothoré
2023-05-17 20:34 ` [PATCH net-next 2/2] net: dsa: mv88e6xxx: enable support for 88E6361 switch alexis.lothore
2023-05-17 20:51 ` Andrew Lunn
2023-05-18 9:11 ` Alexis Lothoré
2023-05-18 12:58 ` Andrew Lunn
2023-05-19 12:38 ` Marek Behún
2023-05-19 13:16 ` Alexis Lothoré
2023-05-19 13:30 ` Andrew Lunn [this message]
2023-05-19 13:32 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85c07e51-8a0b-4328-bab3-acad2ee104e1@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexis.lothore@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=paul.arola@telus.com \
--cc=richardcochran@gmail.com \
--cc=scott.roberts@telus.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®