From: Jim Meyering <jim@meyering.net>
To: Paul Eggert <eggert@CS.UCLA.EDU>
Cc: bug-coreutils@gnu.org, Andrew Morton <akpm@osdl.org>,
Bruce Allen <ballen@gravity.phys.uwm.edu>,
linux-kernel@vger.kernel.org, Andy Isaacson <adi@hexapodia.org>
Subject: Re: dd patch to remove noctty
Date: Thu, 08 Apr 2004 23:40:23 +0200 [thread overview]
Message-ID: <85d66iqhbs.fsf@pi.meyering.net> (raw)
In-Reply-To: <87ekqyw79y.fsf_-_@penguin.cs.ucla.edu> (Paul Eggert's message of "Thu, 08 Apr 2004 13:20:57 -0700")
Paul Eggert <eggert@CS.UCLA.EDU> wrote:
> Philippe Troin <phil@fifi.org> writes:
>
>> noctty definitely seems overkill... I can't see why dd would ever want
>> to open a file without O_NOCTTY.
>
> Good point; it's just a confusion for the user. Here's a patch to
> cause dd to always use O_NOCTTY. If someone ever needs it the other
> way (not likely) I suppose we can add a "ctty" flag.
>
> 2004-04-08 Paul Eggert <eggert@cs.ucla.edu>
>
> * NEWS: Remove noctty flag from dd. Suggested by Philippe Troin.
> * doc/coreutils.texi (dd invocation): Likewise.
> * src/shred.c (O_NOCTTY): Remove redundant decl.
> * src/dd.c (flags, usage): Remove noctty flag.
> (main): Always use O_NOCTTY when opening files.
Applied. Thanks!
next prev parent reply other threads:[~2004-04-08 21:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-06 22:03 dd PATCH: add conv=direct Andy Isaacson
2004-04-07 0:33 ` Andrew Morton
2004-04-07 16:21 ` Bruce Allen
2004-04-07 16:42 ` Andrew Morton
2004-04-07 17:31 ` Andy Isaacson
2004-04-07 18:18 ` Andrew Morton
2004-04-07 19:24 ` Andy Isaacson
2004-04-07 19:34 ` Andrew Morton
2004-04-07 19:47 ` Andy Isaacson
2004-04-07 20:03 ` Andrew Morton
2004-04-07 20:43 ` Andy Isaacson
2004-04-07 21:00 ` Valdis.Kletnieks
2004-04-07 21:35 ` Bruce Allen
2004-04-08 6:56 ` Paul Eggert
2004-04-08 11:07 ` Jim Meyering
2004-04-08 19:32 ` Paul Eggert
2004-04-08 19:51 ` Paul Jarc
2004-04-08 21:34 ` Jim Meyering
2004-04-08 16:23 ` Philippe Troin
2004-04-08 20:20 ` dd patch to remove noctty Paul Eggert
2004-04-08 21:40 ` Jim Meyering [this message]
2004-04-09 0:37 ` dd PATCH: add conv=direct Anton Blanchard
2004-04-09 1:42 ` Wim Coekaerts
2004-04-10 21:28 ` Jim Meyering
2004-04-07 20:46 ` Paul Eggert
2004-04-07 21:06 ` Andrew Morton
2004-04-07 21:09 ` Andy Isaacson
2004-04-07 19:12 ` Miquel van Smoorenburg
2004-04-07 20:14 ` Andy Isaacson
2004-04-07 22:02 ` Nathan Straz
2004-04-07 22:09 ` Andy Isaacson
2004-04-08 11:44 ` Miquel van Smoorenburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85d66iqhbs.fsf@pi.meyering.net \
--to=jim@meyering.net \
--cc=adi@hexapodia.org \
--cc=akpm@osdl.org \
--cc=ballen@gravity.phys.uwm.edu \
--cc=bug-coreutils@gnu.org \
--cc=eggert@CS.UCLA.EDU \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome