From: Jeremy Linton <jeremy.linton@arm.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
linux-kernel@vger.kernel.org
Cc: Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>,
"John B. Wyatt IV" <jwyatt@redhat.com>,
John Kacur <jkacur@redhat.com>,
"open list:CPU POWER MONITORING SUBSYSTEM"
<linux-pm@vger.kernel.org>
Subject: Re: [PATCH] cpupower: Include stdint.h for int64_t in the CPPC helper
Date: Wed, 21 Oct 2026 14:19:55 -0500 [thread overview]
Message-ID: <85f7842d-1728-445f-94a9-c917ffdb0fab@arm.com> (raw)
In-Reply-To: <20261020214721.428420-1-florian.fainelli@broadcom.com>
Hi,
On 10/20/26 4:47 PM, Florian Fainelli wrote:
> cppc_show_perf_and_freq() uses int64_t without including the header that
> defines it. Building cpupower against musl fails with "unknown type name
> 'int64_t'" because the other included headers do not provide the type.
>
> Include stdint.h directly instead of relying on transitive declarations
> from other C library headers.
>
> Fixes: 68f34fad760b ("cpupower: Add generic CPPC performance display")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
> tools/power/cpupower/utils/helpers/cppc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/power/cpupower/utils/helpers/cppc.c b/tools/power/cpupower/utils/helpers/cppc.c
> index 3493ce8551ea..e0e9784fe589 100644
> --- a/tools/power/cpupower/utils/helpers/cppc.c
> +++ b/tools/power/cpupower/utils/helpers/cppc.c
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
>
> #include <stdio.h>
> +#include <stdint.h>
> #include <errno.h>
> #include <stdlib.h>
> #include <string.h>
Looks good, thanks
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
prev parent reply other threads:[~2026-10-21 19:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 21:47 Florian Fainelli
2026-10-21 19:19 ` Jeremy Linton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85f7842d-1728-445f-94a9-c917ffdb0fab@arm.com \
--to=jeremy.linton@arm.com \
--cc=florian.fainelli@broadcom.com \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®