* [PATCH] cpupower: Include stdint.h for int64_t in the CPPC helper
@ 2026-10-20 21:47 Florian Fainelli
2026-10-21 19:19 ` Jeremy Linton
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2026-10-20 21:47 UTC (permalink / raw)
To: linux-kernel
Cc: Florian Fainelli, Thomas Renninger, Shuah Khan, John B. Wyatt IV,
John Kacur, Jeremy Linton,
open list:CPU POWER MONITORING SUBSYSTEM
cppc_show_perf_and_freq() uses int64_t without including the header that
defines it. Building cpupower against musl fails with "unknown type name
'int64_t'" because the other included headers do not provide the type.
Include stdint.h directly instead of relying on transitive declarations
from other C library headers.
Fixes: 68f34fad760b ("cpupower: Add generic CPPC performance display")
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
tools/power/cpupower/utils/helpers/cppc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/power/cpupower/utils/helpers/cppc.c b/tools/power/cpupower/utils/helpers/cppc.c
index 3493ce8551ea..e0e9784fe589 100644
--- a/tools/power/cpupower/utils/helpers/cppc.c
+++ b/tools/power/cpupower/utils/helpers/cppc.c
@@ -1,6 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
#include <stdio.h>
+#include <stdint.h>
#include <errno.h>
#include <stdlib.h>
#include <string.h>
--
2.53.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cpupower: Include stdint.h for int64_t in the CPPC helper
2026-10-20 21:47 [PATCH] cpupower: Include stdint.h for int64_t in the CPPC helper Florian Fainelli
@ 2026-10-21 19:19 ` Jeremy Linton
0 siblings, 0 replies; 2+ messages in thread
From: Jeremy Linton @ 2026-10-21 19:19 UTC (permalink / raw)
To: Florian Fainelli, linux-kernel
Cc: Thomas Renninger, Shuah Khan, John B. Wyatt IV, John Kacur,
open list:CPU POWER MONITORING SUBSYSTEM
Hi,
On 10/20/26 4:47 PM, Florian Fainelli wrote:
> cppc_show_perf_and_freq() uses int64_t without including the header that
> defines it. Building cpupower against musl fails with "unknown type name
> 'int64_t'" because the other included headers do not provide the type.
>
> Include stdint.h directly instead of relying on transitive declarations
> from other C library headers.
>
> Fixes: 68f34fad760b ("cpupower: Add generic CPPC performance display")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
> tools/power/cpupower/utils/helpers/cppc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/power/cpupower/utils/helpers/cppc.c b/tools/power/cpupower/utils/helpers/cppc.c
> index 3493ce8551ea..e0e9784fe589 100644
> --- a/tools/power/cpupower/utils/helpers/cppc.c
> +++ b/tools/power/cpupower/utils/helpers/cppc.c
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
>
> #include <stdio.h>
> +#include <stdint.h>
> #include <errno.h>
> #include <stdlib.h>
> #include <string.h>
Looks good, thanks
Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-21 19:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-20 21:47 [PATCH] cpupower: Include stdint.h for int64_t in the CPPC helper Florian Fainelli
2026-10-21 19:19 ` Jeremy Linton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®