From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xen.org, linux-kernel@vger.kernel.org,
Stefano Stabellini <stefano@aporeto.com>
Subject: Re: [PATCH v2 11/13] xen/pvcalls: implement release command
Date: Tue, 1 Aug 2017 11:57:21 -0400 [thread overview]
Message-ID: <85fbad33-1a27-abaf-f4d2-e93ea47f689c@oracle.com> (raw)
In-Reply-To: <7ace9427-5215-6be7-907a-46dd15ea2a8f@suse.com>
>> BTW, I also noticed that in rcvmsg you are calling
>> wait_event_interruptible() while holding the lock. Have you tested with
>> CONFIG_DEBUG_ATOMIC_SLEEP? (or maybe it's some other config option that
>> would complain about those sorts of thing)
> I believe sleeping while holding a mutex is allowed. Sleeping in
> spinlocked paths is bad.
Oh, right. I was thinking about spinlocks. Sorry.
-boris
>
> BTW: You are looking for CONFIG_DEBUG_MUTEXES (see
> Documentation/locking/mutex-design.txt ).
>
>
> Juergen
next prev parent reply other threads:[~2017-08-01 15:57 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 21:21 [PATCH v2 00/13] introduce the Xen PV Calls frontend Stefano Stabellini
2017-07-25 21:21 ` [PATCH v2 01/13] xen/pvcalls: introduce the pvcalls xenbus frontend Stefano Stabellini
2017-07-25 21:21 ` [PATCH v2 02/13] xen/pvcalls: connect to the backend Stefano Stabellini
2017-07-26 13:35 ` Boris Ostrovsky
2017-07-27 0:26 ` Stefano Stabellini
2017-07-27 15:07 ` Boris Ostrovsky
2017-07-31 21:55 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 03/13] xen/pvcalls: implement socket command and handle events Stefano Stabellini
2017-07-26 14:27 ` Boris Ostrovsky
2017-07-26 23:19 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 04/13] xen/pvcalls: implement connect command Stefano Stabellini
2017-07-26 14:51 ` Boris Ostrovsky
2017-07-26 23:22 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 05/13] xen/pvcalls: implement bind command Stefano Stabellini
2017-07-26 14:56 ` Boris Ostrovsky
2017-07-26 23:59 ` Stefano Stabellini
2017-07-27 14:43 ` Boris Ostrovsky
2017-07-31 22:17 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 06/13] xen/pvcalls: implement listen command Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 07/13] xen/pvcalls: implement accept command Stefano Stabellini
2017-07-26 17:52 ` Boris Ostrovsky
2017-07-26 23:24 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 08/13] xen/pvcalls: implement sendmsg Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 09/13] xen/pvcalls: implement recvmsg Stefano Stabellini
2017-07-26 21:21 ` Boris Ostrovsky
2017-07-26 21:33 ` [Xen-devel] " Boris Ostrovsky
2017-07-27 0:08 ` Stefano Stabellini
2017-07-27 14:59 ` Boris Ostrovsky
2017-07-31 22:26 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 10/13] xen/pvcalls: implement poll command Stefano Stabellini
2017-07-26 23:23 ` Boris Ostrovsky
2017-07-27 0:21 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 11/13] xen/pvcalls: implement release command Stefano Stabellini
2017-07-27 18:39 ` Boris Ostrovsky
2017-07-31 22:34 ` Stefano Stabellini
2017-08-01 15:23 ` Boris Ostrovsky
2017-08-01 15:34 ` Juergen Gross
2017-08-01 15:57 ` Boris Ostrovsky [this message]
2017-09-11 23:56 ` Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 12/13] xen/pvcalls: implement frontend disconnect Stefano Stabellini
2017-07-25 21:22 ` [PATCH v2 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85fbad33-1a27-abaf-f4d2-e93ea47f689c@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stefano@aporeto.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®