mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wei Deng <wei.deng@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	linux-pm@vger.kernel.org, cheng.jiang@oss.qualcomm.com,
	shuai.zhang@oss.qualcomm.com
Subject: Re: [PATCH V3] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
Date: Thu, 26 Feb 2026 17:17:12 +0800	[thread overview]
Message-ID: <860de709-2eb1-407c-88e8-0cc5ee96cd4f@oss.qualcomm.com> (raw)
In-Reply-To: <xuhr6wicgyvc6f3ejq2qnhpb4wk25larvr5frivkwojkq5o3ny@pruh4twsloiu>

Hi Dmitry,

On 2/26/2026 10:27 AM, Dmitry Baryshkov wrote:
> On Wed, Feb 25, 2026 at 02:47:00PM +0530, Wei Deng wrote:
>> Enable BT on qcs8300-ride by adding a BT device tree node.
>>
>> Since the platform uses the QCA6698 Bluetooth chip. While
>> the QCA6698 shares the same IP core as the WCN6855, it has
>> different RF components and RAM sizes, requiring new firmware
>> files. Use the firmware-name property to specify the NVM and
>> rampatch firmware to load.
>>
>> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
>> ---
>> This patch depends on:
>> - WLAN
>> https://lore.kernel.org/all/20260122053624.4068718-1-wei.zhang@oss.qualcomm.com/
>>
>> Changes in v3:
>> - Rebase patches
>> - Remove unintended 'output-low' from bt-en-state pinctrl
>> - Use prerequisite-message-id to replace prerequisite-patch-id (Konrad)
>> - Link to v2: https://lore.kernel.org/all/20251118140406.1551669-2-wei.deng@oss.qualcomm.com/
>>
>> Changes for v2
>> - Update commit message, add firmware name detail
>> - Reorganize patchset
>> - Link to v1: https://lore.kernel.org/all/20251113130942.2661069-1-wei.deng@oss.qualcomm.com/
>> ---
>>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 26 +++++++++++++++++++++++
>>  1 file changed, 26 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> index 2ede6efd1afd..03c01ae630b4 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> @@ -18,6 +18,7 @@ / {
>>  	aliases {
>>  		serial0 = &uart7;
>>  		mmc0 = &sdhc_1;
>> +		serial1 = &uart2;
>>  	};
>>  
>>  	chosen {
>> @@ -107,6 +108,7 @@ wcn6855-pmu {
>>  		vddpcie1p3-supply = <&vreg_conn_1p35>;
>>  		vddpcie1p9-supply = <&vreg_conn_1p95>;
>>  
>> +		bt-enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>;
>>  		wlan-enable-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
>>  
>>  		regulators {
>> @@ -559,6 +561,12 @@ &sdhc_1 {
>>  };
>>  
>>  &tlmm {
>> +	bt_en_state: bt-en-state {
>> +		pins = "gpio55";
>> +		function = "gpio";
>> +		bias-pull-down;
>> +	};
>> +
>>  	pcie0_default_state: pcie0-default-state {
>>  		wake-pins {
>>  			pins = "gpio0";
>> @@ -633,6 +641,24 @@ wlan_en_state: wlan-en-state {
>>  	};
>>  };
>>  
>> +&uart2 {
>> +	status = "okay";
>> +	bluetooth: bluetooth {
> 
> Please add an empty line before the subnode.

Thanks, I’ll add an empty line before the subnode as suggested.

> 
>> +		compatible = "qcom,wcn6855-bt";
>> +		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
>> +		max-speed = <3200000>;
>> +
>> +		vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
>> +		vddaon-supply = <&vreg_pmu_aon_0p59>;
>> +		vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
>> +		vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
>> +		vddbtcmx-supply = <&vreg_pmu_btcmx_0p85>;
>> +		vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
>> +		vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
>> +		vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
>> +	};
>> +};
>> +
>>  &uart7 {
>>  	status = "okay";
>>  };
>>
>> base-commit: 7dff99b354601dd01829e1511711846e04340a69
>> prerequisite-message-id: 20260122053624.4068718-1-wei.zhang@oss.qualcomm.com
>> -- 
>> 2.25.1
>>
> 

-- 
Best Regards,
Wei Deng


  reply	other threads:[~2026-02-26  9:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25  9:17 Wei Deng
2026-02-25 12:27 ` Konrad Dybcio
2026-02-26  9:14   ` Wei Deng
2026-02-26 12:15     ` Konrad Dybcio
2026-03-02  2:34       ` Wei Deng
2026-02-26  2:27 ` Dmitry Baryshkov
2026-02-26  9:17   ` Wei Deng [this message]
2026-02-26  9:18 ` Krzysztof Kozlowski
2026-02-26  9:32   ` Wei Deng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=860de709-2eb1-407c-88e8-0cc5ee96cd4f@oss.qualcomm.com \
    --to=wei.deng@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=brgl@kernel.org \
    --cc=cheng.jiang@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=robh@kernel.org \
    --cc=shuai.zhang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®