mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Simo Sorce <simo@redhat.com>
To: Paul Louvel <paul.louvel@bootlin.com>,
	Thomas Huth <thuth@redhat.com>,  Lukas Wunner <lukas@wunner.de>,
	Ignat Korchagin <ignat@linux.win>,
	Stefan Berger <stefanb@linux.ibm.com>,
	 Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH] crypto: ecc - Add NIST P224 curve parameters
Date: Wed, 29 Jul 2026 15:37:56 -0400	[thread overview]
Message-ID: <86385ae5f9f753e42efde7d0088a494c91639741.camel@redhat.com> (raw)
In-Reply-To: <e59088fb-0a47-4379-8583-546b7e4ec337@bootlin.com>

On Wed, 2026-07-29 at 21:06 +0200, Paul Louvel wrote:
> Hi Thomas, Simo,
> 
> On Wed Jul 29, 2026 at 6:43 PM CEST, Thomas Huth wrote:
>  > On 29/07/2026 17.51, Paul Louvel wrote:
>  >> Add the parameters for the NIST P224 curve and define a new curve ID for
>  >> it. Make the curve available in ecc_get_curve().
>  >
>  > May I ask: Who's going to consume this?
> 
> I am in charge of upstreaming the ECDSA and ECDH support of a PKA device. The
> downstream driver is using the NIST P224 curve in it's code internally.
> We are waiting approval to upstream the driver, and I took the initiative to
> send the curve definition ahead of time, as I thought it might be better to have
> this definition in the core rather than in the driver itself.
> 
> This is an old IP that is more than 10 years old, and seeing Simo Sorce's
> comment, it might not be a good idea to use this curve anymore.

I would simply not expose P224 at all, nothing should use it anyway.

Simo.

-- 
Simo Sorce
Distinguished Engineer
RHEL Crypto Team
Red Hat, Inc


  reply	other threads:[~2026-07-29 19:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 15:51 Paul Louvel
2026-07-29 16:43 ` Thomas Huth
2026-07-29 19:06   ` Paul Louvel
2026-07-29 19:37     ` Simo Sorce [this message]
2026-07-29 16:50 ` Simo Sorce
2026-07-29 18:28 ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86385ae5f9f753e42efde7d0088a494c91639741.camel@redhat.com \
    --to=simo@redhat.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=ignat@linux.win \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=paul.louvel@bootlin.com \
    --cc=stefanb@linux.ibm.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®