From: Marc Zyngier <maz@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Oliver Upton <oupton@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
Steffen Eiden <seiden@linux.ibm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Fuad Tabba <fuad.tabba@linux.dev>,
Peter Maydell <peter.maydell@linaro.org>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
linux-kernel@vger.kernel.org,
"Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Subject: Re: [PATCH v4 2/3] KVM: arm64: Block ID register changes after we rely on the values
Date: Wed, 30 Sep 2026 09:20:54 +0100 [thread overview]
Message-ID: <864if740bd.wl-maz@kernel.org> (raw)
In-Reply-To: <20260929-kvm-arm64-idreg-final-v4-2-75296dde994d@kernel.org>
On Tue, 29 Sep 2026 12:57:59 +0100,
Mark Brown <broonie@kernel.org> wrote:
[...]
> +#define kvm_id_regs_final(kvm) \
> + test_bit(KVM_ARCH_FLAG_ID_REGS_FINAL, &(kvm)->arch.flags)
> +
> +#define vcpu_id_regs_final(vcpu) \
> + kvm_id_regs_final((vcpu)->kvm)
> +
This second helper really gives the wrong idea (idregs are never
vcpu-specific with KVM). I've dropped it when applying this series.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2026-09-30 8:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 11:57 [PATCH v4 0/3] KVM: arm64: ID register finalisation fixes Mark Brown
2026-09-29 11:57 ` [PATCH v4 1/3] KVM: arm64: Finalize guest-wide sysregs prior to per-vCPU sysregs Mark Brown
2026-09-29 11:57 ` [PATCH v4 2/3] KVM: arm64: Block ID register changes after we rely on the values Mark Brown
2026-09-30 8:20 ` Marc Zyngier [this message]
2026-09-29 11:58 ` [PATCH v4 3/3] KVM: arm64: selftests: Check ID regs are immutable after a failed run Mark Brown
2026-09-29 23:02 ` [PATCH v4 0/3] KVM: arm64: ID register finalisation fixes Oliver Upton
2026-09-30 8:32 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864if740bd.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=fuad.tabba@linux.dev \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ljs@kernel.org \
--cc=oupton@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=seiden@linux.ibm.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®