[PATCH 2/2] x86-64: change the size for interrupt array to NR_VECTORS

[PATCH 2/2] x86-64: change the size for interrupt array to NR_VECTORS

[Yinghai Lu]

[-- Attachment #1: Type: text/plain, Size: 24 bytes --]

Please check the patch.

[-- Attachment #2: i8259.patch --]
[-- Type: text/x-patch, Size: 869 bytes --]

[PATCH] x86_64: interrupt array size should be aligned to NR_VECTORS
interrupt array is referred for idt vectors instead of NR_IRQS, so change size
to NR_VECTORS - FIRST_EXTERNAL_VECTOR. Also change to static.

Signed-off-by: Yinghai Lu <yinghai@amd.com>

diff --git a/arch/x86_64/kernel/i8259.c b/arch/x86_64/kernel/i8259.c
index c4ef801..d73c79e 100644
--- a/arch/x86_64/kernel/i8259.c
+++ b/arch/x86_64/kernel/i8259.c
@@ -76,7 +76,8 @@ #define IRQLIST_16(x) \
 	IRQ(x,8), IRQ(x,9), IRQ(x,a), IRQ(x,b), \
 	IRQ(x,c), IRQ(x,d), IRQ(x,e), IRQ(x,f)
 
-void (*interrupt[NR_IRQS])(void) = {
+/* for the irq vectors */
+static void (*interrupt[NR_VECTORS - FIRST_EXTERNAL_VECTOR])(void) = {
 					  IRQLIST_16(0x2), IRQLIST_16(0x3),
 	IRQLIST_16(0x4), IRQLIST_16(0x5), IRQLIST_16(0x6), IRQLIST_16(0x7),
 	IRQLIST_16(0x8), IRQLIST_16(0x9), IRQLIST_16(0xa), IRQLIST_16(0xb),

Re: [PATCH 2/2] x86-64: change the size for interrupt array to NR_VECTORS

[Eric W. Biederman]

"Yinghai Lu" <yinghai.lu@amd.com> writes:

> Please check the patch.

YH.  Please place a newline between your subject and your description
in the body of your patches.

> [PATCH] x86_64: interrupt array size should be aligned to NR_VECTORS
>
> interrupt array is referred for idt vectors instead of NR_IRQS, so change size
> to NR_VECTORS - FIRST_EXTERNAL_VECTOR. Also change to static.
>
> Signed-off-by: Yinghai Lu <yinghai@amd.com>

Acked-by:  Eric Biederman <ebiederm@xmission.com>

Yep I missed this optimization opportunity :)

Eric

Re: [PATCH 2/2] x86-64: change the size for interrupt array to NR_VECTORS

[Yinghai Lu]

On 11/24/06, Eric W. Biederman <ebiederm@xmission.com> wrote:
> "Yinghai Lu" <yinghai.lu@amd.com> writes:
> YH.  Please place a newline between your subject and your description
> in the body of your patches.

Next time.

> Yep I missed this optimization opportunity :)

You did a great job to clean up the irq_vector mapping.

YH

Re: [PATCH 2/2] x86-64: change the size for interrupt array to NR_VECTORS

[Eric W. Biederman]

"Yinghai Lu" <yinghai.lu@amd.com> writes:

> On 11/24/06, Eric W. Biederman <ebiederm@xmission.com> wrote:
>> "Yinghai Lu" <yinghai.lu@amd.com> writes:
>> YH.  Please place a newline between your subject and your description
>> in the body of your patches.
>
> Next time.
>
>> Yep I missed this optimization opportunity :)
>
> You did a great job to clean up the irq_vector mapping.

Yep and created many new optimization and clean up opportunities...
Because I didn't take everything to it's full logical conclusion :)

Just enough to make everything architecture specific.

Eric