From: "Yinghai Lu" <yinghai.lu@amd.com>
To: "Andrew Morton" <akpm@osdl.org>, "Andi Kleen" <ak@muc.de>,
"Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] x86: when acpi_noirq is set, use mptable instead of MADT
Date: Sun, 26 Nov 2006 15:24:32 -0800 [thread overview]
Message-ID: <86802c440611261524p6b170f50rf7db3eafd4f7602e@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ai_3.diff --]
[-- Type: text/x-patch; name="ai_3.diff", Size: 1150 bytes --]
[PATCH 3/3] x86: when acpi_noirq is set, use mptable instead of MADT
When using pci=noacpi, or apci=noirq, acpi_noirq is set. We should skip
acpi_process_madt. Because it will set acpi_lapic and acpi_ioapic, at last
mptable is skipped, but we need io apic routing table in mptable.
Signed-off-by: Yinghai Lu <yinghai.lu@amd.com>
diff --git a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel/acpi/boot.c
index d12fb97..6d62dd1 100644
--- a/arch/i386/kernel/acpi/boot.c
+++ b/arch/i386/kernel/acpi/boot.c
@@ -1242,7 +1242,15 @@ int __init acpi_boot_init(void)
/*
* Process the Multiple APIC Description Table (MADT), if present
*/
- acpi_process_madt();
+ /* with acpi_noirq we don't need to process madt, it will set
+ * acpi_lapic and acpi_ioapic, they will make get_smp_config aka.
+ * MPTABLE be skipped and mp_irqs will not include entries for
+ * irq routing for io apic, then pirq_enable_irq together with
+ * IO_APIC_get_PCI_irq_vector can not find irq in mp_irqs for
+ * devices that are using IOAPIC
+ */
+ if(!acpi_noirq && !acpi_pci_disabled)
+ acpi_process_madt();
acpi_table_parse(ACPI_HPET, acpi_parse_hpet);
next reply other threads:[~2006-11-26 23:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-26 23:24 Yinghai Lu [this message]
2006-11-27 0:23 ` Andi Kleen
2006-11-27 5:37 ` Len Brown
2006-11-27 7:37 ` Yinghai Lu
2006-11-28 5:09 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440611261524p6b170f50rf7db3eafd4f7602e@mail.gmail.com \
--to=yinghai.lu@amd.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®