From: "Yinghai Lu" <yinghai.lu@amd.com>
To: "Len Brown" <lenb@kernel.org>
Cc: "Andrew Morton" <akpm@osdl.org>, "Andi Kleen" <ak@muc.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86: when acpi_noirq is set, use mptable instead of MADT
Date: Mon, 27 Nov 2006 21:09:19 -0800 [thread overview]
Message-ID: <86802c440611272109n8a847f7ia61e247bdd16fa49@mail.gmail.com> (raw)
In-Reply-To: <200611270037.53964.len.brown@intel.com>
[-- Attachment #1: Type: text/plain, Size: 32 bytes --]
Please check the updated patch.
[-- Attachment #2: ai_4.diff --]
[-- Type: text/x-patch, Size: 1178 bytes --]
[PATCH 3/3] x86: when acpi_noirq is set, use mptable instead of MADT
If no DSDT found, call acpi_disable_pci
When using pci=noacpi, or apci=noirq, acpi_noirq is set. We should skip
acpi_process_madt. So to avoid enumerate lapic two times.
Signed-off-by: Yinghai Lu <yinghai.lu@amd.com>
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index bfb3bfc..f497d78 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -297,6 +297,7 @@ acpi_get_table_header_early(enum acpi_ta
if (!*header) {
printk(KERN_WARNING PREFIX "Unable to map DSDT\n");
+ acpi_disable_pci();
return -ENODEV;
}
}
diff --git a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel/acpi/boot.c
index d12fb97..0d350d0 100644
--- a/arch/i386/kernel/acpi/boot.c
+++ b/arch/i386/kernel/acpi/boot.c
@@ -1242,7 +1242,11 @@ int __init acpi_boot_init(void)
/*
* Process the Multiple APIC Description Table (MADT), if present
*/
- acpi_process_madt();
+ /* with acpi_noirq we don't need to process madt, So don't need
+ * ennumerate lapic two times
+ */
+ if(!acpi_noirq && !acpi_pci_disabled)
+ acpi_process_madt();
acpi_table_parse(ACPI_HPET, acpi_parse_hpet);
prev parent reply other threads:[~2006-11-28 5:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-26 23:24 Yinghai Lu
2006-11-27 0:23 ` Andi Kleen
2006-11-27 5:37 ` Len Brown
2006-11-27 7:37 ` Yinghai Lu
2006-11-28 5:09 ` Yinghai Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440611272109n8a847f7ia61e247bdd16fa49@mail.gmail.com \
--to=yinghai.lu@amd.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®