mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "David Rientjes" <rientjes@google.com>
Cc: "Andi Kleen" <ak@suse.de>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86_64: offset apicid_to_node before use it before init_cpu_to_node
Date: Sun, 22 Jul 2007 01:17:06 -0700	[thread overview]
Message-ID: <86802c440707220117x1ce64d1asfac29747a1d81710@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.0.99.0707220104550.6665@chino.kir.corp.google.com>

On 7/22/07, David Rientjes <rientjes@google.com> wrote:
> On Sat, 21 Jul 2007, Yinghai Lu wrote:
>
> > [PATCH 3/3] x86_64: offset apicid_to_node before use it before
> > init_cpu_to_node
> >
>
> Does this preserve the correct fake apicid_to_node mapping for the
> emulated case such as numa=fake=32?
>
+void __init update_apicid_to_node(void)
+{
+       /*
+        * let modify apicid_to_node array when boot_cpu_id !=0
+        * apicid_to_node[0] != NUMA_NODE
+        */
+
+       int i;
+
+       /* there is no apic id offset */
+       if (!boot_cpu_id)
+               return;
+
+       /* check if it is already updated */
+       if (apicid_to_node[0] == NUMA_NO_NODE)
+               return;

boot_cpu_id (bsp apic id ) is 0 under fake numa case?

or need to add some exit for fake numa mode.

YH

  reply	other threads:[~2007-07-22  8:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-22  0:49 Yinghai Lu
2007-07-22  8:05 ` David Rientjes
2007-07-22  8:17   ` Yinghai Lu [this message]
2007-07-22 12:52 ` Andi Kleen
2007-07-22 22:54   ` Yinghai Lu
2007-07-23  0:29     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440707220117x1ce64d1asfac29747a1d81710@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®