From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Gary Hade <garyhade@us.ibm.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
mingo@elte.hu, mingo@redhat.com, tglx@linutronix.de,
hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org,
lcm@us.ibm.com
Subject: Re: [PATCH 3/3] [BUGFIX] x86/x86_64: fix IRQ migration triggered active device IRQ interrruption
Date: Sat, 11 Apr 2009 00:35:09 -0700 [thread overview]
Message-ID: <86802c440904110035m4cec46f5n5ab7d43e00f42d9f@mail.gmail.com> (raw)
In-Reply-To: <20090410213943.GB7242@us.ibm.com>
On Fri, Apr 10, 2009 at 2:39 PM, Gary Hade <garyhade@us.ibm.com> wrote:
> move_masked_irq() clears the IRQ_MOVE_PENDING desc->status
> bit before calling the function pointed to by
> desc->chip->set_affinity [e.g. set_ioapic_affinity_irq()]
> AND the content of desc->pending_mask is not used after
> cpumask_and(desc->affinity, desc->pending_mask, cpu_online_mask);
> which precedes the set_affinity function call. So, I believe
> this provides the necessary separation between the
> IRQ_MOVE_PENDING/desc->pending_mask useage in move_masked_irq()
> and the IRQ_MOVE_PENDING/desc->pending_mask useage in the code
> that the patch adds.
>
that should be ok, they are proteced by spin_lock(&desc->lock)
YH
prev parent reply other threads:[~2009-04-11 7:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-08 21:07 Gary Hade
2009-04-08 22:03 ` Yinghai Lu
2009-04-08 23:08 ` Gary Hade
2009-04-11 6:46 ` Yinghai Lu
2009-04-13 19:37 ` Gary Hade
2009-04-13 20:17 ` Eric W. Biederman
2009-04-28 0:05 ` Gary Hade
2009-04-28 10:27 ` Eric W. Biederman
2009-04-29 0:44 ` Gary Hade
2009-04-29 1:44 ` Eric W. Biederman
2009-04-29 17:17 ` Gary Hade
2009-04-29 17:46 ` Eric W. Biederman
2009-04-30 18:15 ` Gary Hade
2009-04-30 21:17 ` Gary Hade
2009-05-24 0:24 ` Yinghai Lu
2009-04-10 21:39 ` Gary Hade
2009-04-11 7:35 ` Yinghai Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440904110035m4cec46f5n5ab7d43e00f42d9f@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=ebiederm@xmission.com \
--cc=garyhade@us.ibm.com \
--cc=hpa@zytor.com \
--cc=lcm@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®