mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v1] mmc: sdhci-of-dwcmshc: fix DMA 128MB boundary
@ 2026-01-14 12:22 hehuan1
  2026-01-21  6:41 ` Adrian Hunter
  2026-01-22 18:03 ` Ulf Hansson
  0 siblings, 2 replies; 3+ messages in thread
From: hehuan1 @ 2026-01-14 12:22 UTC (permalink / raw)
  To: adrian.hunter, ulf.hansson, linux-mmc, linux-kernel
  Cc: ningyu, linmin, pinkesh.vaghela, xuxiang, hehuan1

From: Huan He <hehuan1@eswincomputing.com>

This DWC MSHC has a 128MB limitation where the data buffer size and start
address must not exceed the 128MB boundary. Registering the missing
'adma_write_desc' callback function.

Signed-off-by: Huan He <hehuan1@eswincomputing.com>
---
 drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
index 51949cde0958..cabb709a8108 100644
--- a/drivers/mmc/host/sdhci-of-dwcmshc.c
+++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
@@ -1726,6 +1726,7 @@ static const struct sdhci_ops sdhci_dwcmshc_eic7700_ops = {
 	.set_uhs_signaling = sdhci_eic7700_set_uhs_wrapper,
 	.set_power = sdhci_set_power_and_bus_voltage,
 	.irq = dwcmshc_cqe_irq_handler,
+	.adma_write_desc = dwcmshc_adma_write_desc,
 	.platform_execute_tuning = sdhci_eic7700_executing_tuning,
 };
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] mmc: sdhci-of-dwcmshc: fix DMA 128MB boundary
  2026-01-14 12:22 [PATCH v1] mmc: sdhci-of-dwcmshc: fix DMA 128MB boundary hehuan1
@ 2026-01-21  6:41 ` Adrian Hunter
  2026-01-22 18:03 ` Ulf Hansson
  1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2026-01-21  6:41 UTC (permalink / raw)
  To: hehuan1, ulf.hansson, linux-mmc, linux-kernel
  Cc: ningyu, linmin, pinkesh.vaghela, xuxiang

On 14/01/2026 14:22, hehuan1@eswincomputing.com wrote:
> From: Huan He <hehuan1@eswincomputing.com>
> 
> This DWC MSHC has a 128MB limitation where the data buffer size and start
> address must not exceed the 128MB boundary. Registering the missing
> 'adma_write_desc' callback function.
> 
> Signed-off-by: Huan He <hehuan1@eswincomputing.com>

Fixes tag?

Nevertheless:

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index 51949cde0958..cabb709a8108 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -1726,6 +1726,7 @@ static const struct sdhci_ops sdhci_dwcmshc_eic7700_ops = {
>  	.set_uhs_signaling = sdhci_eic7700_set_uhs_wrapper,
>  	.set_power = sdhci_set_power_and_bus_voltage,
>  	.irq = dwcmshc_cqe_irq_handler,
> +	.adma_write_desc = dwcmshc_adma_write_desc,
>  	.platform_execute_tuning = sdhci_eic7700_executing_tuning,
>  };
>  


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] mmc: sdhci-of-dwcmshc: fix DMA 128MB boundary
  2026-01-14 12:22 [PATCH v1] mmc: sdhci-of-dwcmshc: fix DMA 128MB boundary hehuan1
  2026-01-21  6:41 ` Adrian Hunter
@ 2026-01-22 18:03 ` Ulf Hansson
  1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2026-01-22 18:03 UTC (permalink / raw)
  To: hehuan1
  Cc: adrian.hunter, linux-mmc, linux-kernel, ningyu, linmin,
	pinkesh.vaghela, xuxiang

On Wed, 14 Jan 2026 at 13:23, <hehuan1@eswincomputing.com> wrote:
>
> From: Huan He <hehuan1@eswincomputing.com>
>
> This DWC MSHC has a 128MB limitation where the data buffer size and start
> address must not exceed the 128MB boundary. Registering the missing
> 'adma_write_desc' callback function.
>
> Signed-off-by: Huan He <hehuan1@eswincomputing.com>

Applied for fixes and by adding a fixes tag, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-of-dwcmshc.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index 51949cde0958..cabb709a8108 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -1726,6 +1726,7 @@ static const struct sdhci_ops sdhci_dwcmshc_eic7700_ops = {
>         .set_uhs_signaling = sdhci_eic7700_set_uhs_wrapper,
>         .set_power = sdhci_set_power_and_bus_voltage,
>         .irq = dwcmshc_cqe_irq_handler,
> +       .adma_write_desc = dwcmshc_adma_write_desc,
>         .platform_execute_tuning = sdhci_eic7700_executing_tuning,
>  };
>
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-01-22 18:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-01-14 12:22 [PATCH v1] mmc: sdhci-of-dwcmshc: fix DMA 128MB boundary hehuan1
2026-01-21  6:41 ` Adrian Hunter
2026-01-22 18:03 ` Ulf Hansson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®