From: John Garry <john.garry@huawei.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: <peterz@infradead.org>, <acme@kernel.org>, <mark.rutland@arm.com>,
<alexander.shishkin@linux.intel.com>, <namhyung@kernel.org>,
<mingo@redhat.com>, <irogers@google.com>,
<linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kjain@linux.ibm.com>,
<james.clark@arm.com>
Subject: Re: [PATCH v2 2/2] perf jevents: Enable warnings through HOSTCFLAGS
Date: Fri, 22 Oct 2021 10:42:11 +0100 [thread overview]
Message-ID: <86aee893-0b6b-bce3-d1aa-3b66365592d1@huawei.com> (raw)
In-Reply-To: <YXFhr2YoVp9GPsDM@krava>
On 21/10/2021 13:48, Jiri Olsa wrote:
>> +HOSTCFLAGS += -Wall
>> +HOSTCFLAGS += -Wextra
>> +
>> # Enforce a non-executable stack, as we may regress (again) in the future by
>> # adding assembler files missing the .GNU-stack linker note.
>> LDFLAGS += -Wl,-z,noexecstack
>> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
>> index 7df13e74450c..118bcdc70bb4 100644
>> --- a/tools/perf/Makefile.perf
>> +++ b/tools/perf/Makefile.perf
>> @@ -226,7 +226,7 @@ else
>> endif
>>
>> export srctree OUTPUT RM CC CXX LD AR CFLAGS CXXFLAGS V BISON FLEX AWK
>> -export HOSTCC HOSTLD HOSTAR
>> +export HOSTCC HOSTLD HOSTAR HOSTCFLAGS
>>
>> include $(srctree)/tools/build/Makefile.include
>>
>> diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
>> index a055dee6a46a..d5c287f069a2 100644
>> --- a/tools/perf/pmu-events/Build
>> +++ b/tools/perf/pmu-events/Build
>> @@ -1,7 +1,7 @@
>> hostprogs := jevents
>>
>> jevents-y += json.o jsmn.o jevents.o
>> -HOSTCFLAGS_jevents.o = -I$(srctree)/tools/include
>> +HOSTCFLAGS_jevents.o = -I$(srctree)/tools/include $(HOSTCFLAGS)
> so the the host cflags are made of:
>
> host_c_flags = -Wp,-MD,$(depfile) -Wp,-MT,$@ $(KBUILD_HOSTCFLAGS) -D"BUILD_STR(s)=\#s" $(HOSTCFLAGS_$(basetarget).o) $(HOSTCFLAGS_$(obj))
>
ok, so IIRC, then the rule for building .o from .c in
tools/build/Makefile.build will pick up HOSTCFLAGS through this
variable, so we then don't need to explicitly mention it in the
per-target rule, so can have this as before in pmu-events/Build
HOSTCFLAGS_jevents.o = -I$(srctree)/tools/include
right?
(Indeed I guess that we can get rid of -I$(srctree)/tools/include as well)
Thanks,
John
> can't you use KBUILD_HOSTCFLAGS?
>
> also perhaps we could rename KBUILD_HOSTCFLAGS to HOSTCFLAGS?
> the name seems like leftover from kbuild move
>
> jirka
>
>> pmu-events-y += pmu-events.o
>> JDIR = pmu-events/arch/$(SRCARCH)
>> JSON = $(shell [ -d $(JDIR) ] &&
next prev parent reply other threads:[~2021-10-22 9:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 9:16 [PATCH v2 0/2] perf jevents: Enable build warnings John Garry
2021-10-21 9:16 ` [PATCH v2 1/2] perf jevents: Fix some would-be warnings John Garry
2021-10-21 9:16 ` [PATCH v2 2/2] perf jevents: Enable warnings through HOSTCFLAGS John Garry
2021-10-21 12:48 ` Jiri Olsa
2021-10-21 15:50 ` John Garry
2021-10-21 15:58 ` Jiri Olsa
2021-10-22 9:42 ` John Garry [this message]
2021-10-25 11:40 ` Jiri Olsa
2021-10-25 16:20 ` Arnaldo Carvalho de Melo
2021-10-28 8:23 ` John Garry
2021-10-28 11:17 ` Arnaldo Carvalho de Melo
2021-10-28 11:40 ` John Garry
2021-10-21 12:55 ` [PATCH v2 0/2] perf jevents: Enable build warnings Arnaldo Carvalho de Melo
2021-10-21 13:02 ` John Garry
2021-10-21 14:36 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86aee893-0b6b-bce3-d1aa-3b66365592d1@huawei.com \
--to=john.garry@huawei.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=jolsa@redhat.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®