mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: <peterz@infradead.org>, <mark.rutland@arm.com>,
	<alexander.shishkin@linux.intel.com>, <jolsa@redhat.com>,
	<namhyung@kernel.org>, <mingo@redhat.com>, <irogers@google.com>,
	<linux-perf-users@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kjain@linux.ibm.com>,
	<james.clark@arm.com>
Subject: Re: [PATCH v2 0/2] perf jevents: Enable build warnings
Date: Thu, 21 Oct 2021 14:02:41 +0100	[thread overview]
Message-ID: <9075dc5c-25a2-c977-a1c2-675e972115e7@huawei.com> (raw)
In-Reply-To: <YXFjSR6ZRQbMjiG3@kernel.org>

On 21/10/2021 13:55, Arnaldo Carvalho de Melo wrote:
> Em Thu, Oct 21, 2021 at 05:16:43PM +0800, John Garry escreveu:
>> Currently jevents builds without any complier warning flags enabled. So
>> use newly-defined HOSTCFLAGS, which comes from EXTRA_WARNINGS.
>>
>> Changes for v2:
>> - Add Werror, Wall, and Wextra (James Clark suggestion)
> 
> Thanks, applied.
> 

Hi Arnaldo,

Can you please wait until I check the review response from jirka?

Thanks

> - Arnaldo
> 
>   
>> Baseline is acme perf/core + mainline commit b94729919db2 ("perf jevents:
>> Free the sys_event_tables list after processing entries"):
>>
>> 680453e63302 perf jevents: Free the sys_event_tables list after processing entries
>> be8ecc57f180 (origin/perf/core) perf srcline: Use long-running addr2line per DSO
>> 2b775152bbe8 perf tests vmlinux-kallsyms: Ignore hidden symbols
>>
>> John Garry (2):
>>    perf jevents: Fix some would-be warnings
>>    perf jevents: Enable warnings through HOSTCFLAGS
>>
>>   tools/perf/Makefile.config      |  5 +++++
>>   tools/perf/Makefile.perf        |  2 +-
>>   tools/perf/pmu-events/Build     |  2 +-
>>   tools/perf/pmu-events/jevents.c | 10 ++++------
>>   4 files changed, 11 insertions(+), 8 deletions(-)
>>
>> -- 
>> 2.17.1
> 


  reply	other threads:[~2021-10-21 13:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21  9:16 John Garry
2021-10-21  9:16 ` [PATCH v2 1/2] perf jevents: Fix some would-be warnings John Garry
2021-10-21  9:16 ` [PATCH v2 2/2] perf jevents: Enable warnings through HOSTCFLAGS John Garry
2021-10-21 12:48   ` Jiri Olsa
2021-10-21 15:50     ` John Garry
2021-10-21 15:58       ` Jiri Olsa
2021-10-22  9:42     ` John Garry
2021-10-25 11:40       ` Jiri Olsa
2021-10-25 16:20         ` Arnaldo Carvalho de Melo
2021-10-28  8:23           ` John Garry
2021-10-28 11:17             ` Arnaldo Carvalho de Melo
2021-10-28 11:40               ` John Garry
2021-10-21 12:55 ` [PATCH v2 0/2] perf jevents: Enable build warnings Arnaldo Carvalho de Melo
2021-10-21 13:02   ` John Garry [this message]
2021-10-21 14:36     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9075dc5c-25a2-c977-a1c2-675e972115e7@huawei.com \
    --to=john.garry@huawei.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@redhat.com \
    --cc=kjain@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®