From: Paolo Bonzini <pbonzini@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>,
rkrcmar@redhat.com, joro@8bytes.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, Thomas.Lendacky@amd.com
Subject: Re: [PATCH v2] KVM: x86: Avoid guest page table walk when gpa_available is set
Date: Thu, 27 Jul 2017 15:49:14 +0200 [thread overview]
Message-ID: <86b4e9e3-b594-4470-375e-10a2a3e6a4ea@redhat.com> (raw)
In-Reply-To: <1495206749-25393-1-git-send-email-brijesh.singh@amd.com>
On 19/05/2017 17:12, Brijesh Singh wrote:
> - vcpu_is_mmio_gpa(vcpu, addr, exception->address, write) &&
> (addr & ~PAGE_MASK) == (exception->address & ~PAGE_MASK)) {
^^^^^^^^^^^^^^^^^^
I think this should be vcpu->arch.gpa_val.
Paolo
> - gpa = exception->address;
> - goto mmio;
> - }
> + gpa = vcpu->arch.gpa_val;
> + ret = vcpu_is_mmio_gpa(vcpu, addr, gpa, write);
> + } else {
>
prev parent reply other threads:[~2017-07-27 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 15:12 Brijesh Singh
2017-05-30 9:05 ` Joerg Roedel
2017-05-30 22:09 ` Brijesh Singh
2017-07-17 21:32 ` Brijesh Singh
2017-07-19 11:19 ` Radim Krčmář
2017-07-19 13:35 ` Brijesh Singh
2017-07-20 7:43 ` Radim Krčmář
2017-08-08 19:24 ` Brijesh Singh
2017-07-27 13:49 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86b4e9e3-b594-4470-375e-10a2a3e6a4ea@redhat.com \
--to=pbonzini@redhat.com \
--cc=Thomas.Lendacky@amd.com \
--cc=brijesh.singh@amd.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®