From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: intel-xe@lists.freedesktop.org,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>, "Will Deacon" <will@kernel.org>,
"Waiman Long" <longman@redhat.com>,
"Maarten Lankhorst" <maarten@lankhorst.se>,
"Christian König" <christian.koenig@amd.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] locking/ww_mutex: Adjust to lockdep nest_lock requirements
Date: Thu, 17 Oct 2024 17:13:09 +0200 [thread overview]
Message-ID: <86b5c0275e43d825b13a71ee2875e8ec48b56578.camel@linux.intel.com> (raw)
In-Reply-To: <Zw_z9FaTiXV090-b@Boquns-Mac-mini.local>
On Wed, 2024-10-16 at 10:12 -0700, Boqun Feng wrote:
> On Wed, Oct 16, 2024 at 08:17:50AM +0200, Thomas Hellström wrote:
> [...]
> > >
> > > So even though first_lock_dep_map is a fake lock, it has to have
> > > the
> > > same wait types as a real mutex.
> >
> > Understood.
> > >
> > > Does this make sense?
> >
> > Yes it does. I'll update to a v3, and add a Tested-by: tag. Would
> > you
>
> I think you should send a v3 then after I test, I will send my
> Tested-by.
>
> > like a Co-developed-by: tag as well?
>
> It's not a big change onto yours, but feel free to add it.
It would probably have taken me considerable time to find that missing
LD_WAIT_SLEEP, but I forgot to ask for your S-O-B so I sent the patch
without. Perhaps can be added at commit time if needed.
Thanks again,
Thomas
>
> Regards,
> Boqun
>
> >
> > Thanks,
> > Thomas
> >
> >
> [...]
prev parent reply other threads:[~2024-10-17 15:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 9:20 Thomas Hellström
2024-10-09 13:10 ` Peter Zijlstra
2024-10-09 13:43 ` Thomas Hellström
2024-10-09 13:20 ` [tip: locking/core] " tip-bot2 for Thomas Hellström
2024-10-14 20:23 ` [PATCH v2] " Boqun Feng
2024-10-15 11:03 ` Thomas Hellström
2024-10-15 15:27 ` Thomas Hellström
2024-10-15 18:00 ` Boqun Feng
2024-10-16 6:17 ` Thomas Hellström
2024-10-16 17:12 ` Boqun Feng
2024-10-17 15:13 ` Thomas Hellström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86b5c0275e43d825b13a71ee2875e8ec48b56578.camel@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=boqun.feng@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=maarten@lankhorst.se \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome