[git pull] drm intel hibernation fix

[git pull] drm intel hibernation fix

[Dave Airlie]

Hi Linus,

I tracked down the misc memory corruption after i915 hibernate to the 
blinking fbcon cursor, and realised the i915 driver wasn't doing the fbdev 
suspend/resume calls at all. nouveau and radeon have done these calls for 
a long time.

This has been fairly well tested and is definitely the main culprit in 
hibernate not working.

Dave.

The following changes since commit d936622c36273a9ecfbb4aacf26cd29405995159:

  drm/radeon: Only warn if the intra-domain offset actually exceeds the limit. (2012-03-28 13:50:05 +0100)

are available in the git repository at:
  git://people.freedesktop.org/~airlied/linux drm-fixes

Dave Airlie (1):
      drm/i915: suspend fbdev device around suspend/hibernate

 drivers/gpu/drm/i915/i915_drv.c  |    7 +++++++
 drivers/gpu/drm/i915/intel_drv.h |    2 +-
 drivers/gpu/drm/i915/intel_fb.c  |   10 ++++++++++
 3 files changed, 18 insertions(+), 1 deletions(-)

Re: [git pull] drm intel hibernation fix

[Keith Packard]

<#part sign=pgpmime>
On Thu, 29 Mar 2012 08:14:08 +0100 (IST), Dave Airlie <airlied@linux.ie> wrote:

> Dave Airlie (1):
>       drm/i915: suspend fbdev device around suspend/hibernate

This has my Reviewed-by on it; Dave suggested just sending it directly
to you instead of running it through my tree and then back through
his...

-- 
keith.packard@intel.com

Re: [git pull] drm intel hibernation fix

[richard -rw- weinberger]

On Thu, Mar 29, 2012 at 9:34 AM, Keith Packard <keithp@keithp.com> wrote:
> <#part sign=pgpmime>
> On Thu, 29 Mar 2012 08:14:08 +0100 (IST), Dave Airlie <airlied@linux.ie> wrote:
>
>> Dave Airlie (1):
>>       drm/i915: suspend fbdev device around suspend/hibernate
>

I've reported the issue one year ago and kept the discussion
alive until the problem was found and resolved:
https://lkml.org/lkml/2011/3/23/360

Nevertheless I'm not mentioned with a Reported-by. :-(

-- 
Thanks,
//richard

Re: [git pull] drm intel hibernation fix

[Eugeni Dodonov]

On Thu, Mar 29, 2012 at 16:43, richard -rw- weinberger
<richard.weinberger@gmail.com> wrote:
> On Thu, Mar 29, 2012 at 9:34 AM, Keith Packard <keithp@keithp.com> wrote:
>> <#part sign=pgpmime>
>> On Thu, 29 Mar 2012 08:14:08 +0100 (IST), Dave Airlie <airlied@linux.ie> wrote:
>>
>>> Dave Airlie (1):
>>>       drm/i915: suspend fbdev device around suspend/hibernate
>>
>
> I've reported the issue one year ago and kept the discussion
> alive until the problem was found and resolved:
> https://lkml.org/lkml/2011/3/23/360

For the historical purposes, I think this would also fix
https://bugs.freedesktop.org/show_bug.cgi?id=35648 and
https://bugs.freedesktop.org/show_bug.cgi?id=40241 as well.

-- 
Eugeni Dodonov