From: Marc Zyngier <marc.zyngier@arm.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
will@kernel.org, Linux ARM <linux-arm-kernel@lists.infradead.org>,
kvmarm@lists.cs.columbia.edu,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] arm64: KVM: hyp: debug-sr: Mark expected switch fall-through
Date: Mon, 29 Jul 2019 10:49:00 +0100 [thread overview]
Message-ID: <86tvb5mar7.wl-marc.zyngier@arm.com> (raw)
In-Reply-To: <CADYN=9KmNwsP7TDkf30xCa8ARVzQ_q=-v8cwkFueQ+NT-9JdyQ@mail.gmail.com>
On Fri, 26 Jul 2019 15:11:05 +0100,
Anders Roxell <anders.roxell@linaro.org> wrote:
>
> On Fri, 26 Jul 2019 at 14:31, Marc Zyngier <marc.zyngier@arm.com> wrote:
> >
> > On Fri, 26 Jul 2019 12:27:10 +0100,
> > Anders Roxell <anders.roxell@linaro.org> wrote:
> > >
> > > When fall-through warnings was enabled by default the following warnings
> > > was starting to show up:
> > >
> > > ../arch/arm64/kvm/hyp/debug-sr.c: In function ‘__debug_save_state’:
> > > ../arch/arm64/kvm/hyp/debug-sr.c:20:19: warning: this statement may fall
> > > through [-Wimplicit-fallthrough=]
> > > case 15: ptr[15] = read_debug(reg, 15); \
> > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’
> > > save_debug(dbg->dbg_bcr, dbgbcr, brps);
> > > ^~~~~~~~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:21:2: note: here
> > > case 14: ptr[14] = read_debug(reg, 14); \
> > > ^~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’
> > > save_debug(dbg->dbg_bcr, dbgbcr, brps);
> > > ^~~~~~~~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:21:19: warning: this statement may fall
> > > through [-Wimplicit-fallthrough=]
> > > case 14: ptr[14] = read_debug(reg, 14); \
> > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’
> > > save_debug(dbg->dbg_bcr, dbgbcr, brps);
> > > ^~~~~~~~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:22:2: note: here
> > > case 13: ptr[13] = read_debug(reg, 13); \
> > > ^~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’
> > > save_debug(dbg->dbg_bcr, dbgbcr, brps);
> > > ^~~~~~~~~~
> > >
> > > Rework to add a 'break;' where the compiler warned about
> > > fall-through.
> >
> > That's not what this patch does, I'm afraid.
>
> urgh I'm sorry.
> Sending a v2 shortly.
Don't bother, I'll fix it locally.
Thanks,
M.
--
Jazz is not dead, it just smells funny.
prev parent reply other threads:[~2019-07-29 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 11:27 Anders Roxell
2019-07-26 12:31 ` Marc Zyngier
2019-07-26 14:11 ` Anders Roxell
2019-07-29 9:49 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86tvb5mar7.wl-marc.zyngier@arm.com \
--to=marc.zyngier@arm.com \
--cc=anders.roxell@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®