* [PATCH 1/1] thermal/of: Add OF node address to output message
@ 2026-03-05 16:35 Alexander Stein
2026-03-06 13:49 ` Lukasz Luba
2026-03-06 17:47 ` Daniel Lezcano
0 siblings, 2 replies; 4+ messages in thread
From: Alexander Stein @ 2026-03-05 16:35 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba
Cc: Alexander Stein, linux-pm, linux-kernel
Temperature sensors are supposed to have the DT node name
temperature-sensors. Having multiple ones the node name alone isn't very
helpful. Add the node address to make them more distinguishable.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Old error messages:
thermal_sys: Failed to find thermal zone for temperature-sensor id=0
thermal_sys: Failed to find thermal zone for temperature-sensor id=0
New error messages:
thermal_sys: Failed to find thermal zone for temperature-sensor@1c id=0
thermal_sys: Failed to find thermal zone for temperature-sensor@1b id=0
drivers/thermal/thermal_of.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
index 6ebb83cb70b2f..99085c806a1f6 100644
--- a/drivers/thermal/thermal_of.c
+++ b/drivers/thermal/thermal_of.c
@@ -144,7 +144,7 @@ static struct device_node *of_thermal_zone_find(struct device_node *sensor, int
count = of_count_phandle_with_args(child, "thermal-sensors",
"#thermal-sensor-cells");
if (count <= 0) {
- pr_err("%pOFn: missing thermal sensor\n", child);
+ pr_err("%pOFP: missing thermal sensor\n", child);
return ERR_PTR(-EINVAL);
}
@@ -156,14 +156,14 @@ static struct device_node *of_thermal_zone_find(struct device_node *sensor, int
"#thermal-sensor-cells",
i, &sensor_specs);
if (ret < 0) {
- pr_err("%pOFn: Failed to read thermal-sensors cells: %d\n", child, ret);
+ pr_err("%pOFP: Failed to read thermal-sensors cells: %d\n", child, ret);
return ERR_PTR(ret);
}
of_node_put(sensor_specs.np);
if ((sensor == sensor_specs.np) && id == (sensor_specs.args_count ?
sensor_specs.args[0] : 0)) {
- pr_debug("sensor %pOFn id=%d belongs to %pOFn\n", sensor, id, child);
+ pr_debug("sensor %pOFP id=%d belongs to %pOFP\n", sensor, id, child);
return no_free_ptr(child);
}
}
@@ -180,7 +180,7 @@ static int thermal_of_monitor_init(struct device_node *np, int *delay, int *pdel
if (ret == -EINVAL) {
*pdelay = 0;
} else if (ret < 0) {
- pr_err("%pOFn: Couldn't get polling-delay-passive: %d\n", np, ret);
+ pr_err("%pOFP: Couldn't get polling-delay-passive: %d\n", np, ret);
return ret;
}
@@ -188,7 +188,7 @@ static int thermal_of_monitor_init(struct device_node *np, int *delay, int *pdel
if (ret == -EINVAL) {
*delay = 0;
} else if (ret < 0) {
- pr_err("%pOFn: Couldn't get polling-delay: %d\n", np, ret);
+ pr_err("%pOFP: Couldn't get polling-delay: %d\n", np, ret);
return ret;
}
@@ -380,23 +380,23 @@ static struct thermal_zone_device *thermal_of_zone_register(struct device_node *
np = of_thermal_zone_find(sensor, id);
if (IS_ERR(np)) {
if (PTR_ERR(np) != -ENODEV)
- pr_err("Failed to find thermal zone for %pOFn id=%d\n", sensor, id);
+ pr_err("Failed to find thermal zone for %pOFP id=%d\n", sensor, id);
return ERR_CAST(np);
}
trips = thermal_of_trips_init(np, &ntrips);
if (IS_ERR(trips)) {
- pr_err("Failed to parse trip points for %pOFn id=%d\n", sensor, id);
+ pr_err("Failed to parse trip points for %pOFP id=%d\n", sensor, id);
ret = PTR_ERR(trips);
goto out_of_node_put;
}
if (!trips)
- pr_info("No trip points found for %pOFn id=%d\n", sensor, id);
+ pr_info("No trip points found for %pOFP id=%d\n", sensor, id);
ret = thermal_of_monitor_init(np, &delay, &pdelay);
if (ret) {
- pr_err("Failed to initialize monitoring delays from %pOFn\n", np);
+ pr_err("Failed to initialize monitoring delays from %pOFP\n", np);
goto out_kfree_trips;
}
@@ -417,7 +417,7 @@ static struct thermal_zone_device *thermal_of_zone_register(struct device_node *
pdelay, delay);
if (IS_ERR(tz)) {
ret = PTR_ERR(tz);
- pr_err("Failed to register thermal zone %pOFn: %d\n", np, ret);
+ pr_err("Failed to register thermal zone %pOFP: %d\n", np, ret);
goto out_kfree_trips;
}
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] thermal/of: Add OF node address to output message
2026-03-05 16:35 [PATCH 1/1] thermal/of: Add OF node address to output message Alexander Stein
@ 2026-03-06 13:49 ` Lukasz Luba
2026-03-06 14:41 ` Daniel Lezcano
2026-03-06 17:47 ` Daniel Lezcano
1 sibling, 1 reply; 4+ messages in thread
From: Lukasz Luba @ 2026-03-06 13:49 UTC (permalink / raw)
To: Alexander Stein
Cc: linux-pm, linux-kernel, Zhang Rui, Daniel Lezcano, Rafael J. Wysocki
On 3/5/26 16:35, Alexander Stein wrote:
> Temperature sensors are supposed to have the DT node name
> temperature-sensors. Having multiple ones the node name alone isn't very
> helpful. Add the node address to make them more distinguishable.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Old error messages:
> thermal_sys: Failed to find thermal zone for temperature-sensor id=0
> thermal_sys: Failed to find thermal zone for temperature-sensor id=0
>
> New error messages:
> thermal_sys: Failed to find thermal zone for temperature-sensor@1c id=0
> thermal_sys: Failed to find thermal zone for temperature-sensor@1b id=0
>
> drivers/thermal/thermal_of.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
> index 6ebb83cb70b2f..99085c806a1f6 100644
> --- a/drivers/thermal/thermal_of.c
> +++ b/drivers/thermal/thermal_of.c
> @@ -144,7 +144,7 @@ static struct device_node *of_thermal_zone_find(struct device_node *sensor, int
> count = of_count_phandle_with_args(child, "thermal-sensors",
> "#thermal-sensor-cells");
> if (count <= 0) {
> - pr_err("%pOFn: missing thermal sensor\n", child);
> + pr_err("%pOFP: missing thermal sensor\n", child);
> return ERR_PTR(-EINVAL);
> }
>
> @@ -156,14 +156,14 @@ static struct device_node *of_thermal_zone_find(struct device_node *sensor, int
> "#thermal-sensor-cells",
> i, &sensor_specs);
> if (ret < 0) {
> - pr_err("%pOFn: Failed to read thermal-sensors cells: %d\n", child, ret);
> + pr_err("%pOFP: Failed to read thermal-sensors cells: %d\n", child, ret);
> return ERR_PTR(ret);
> }
>
> of_node_put(sensor_specs.np);
> if ((sensor == sensor_specs.np) && id == (sensor_specs.args_count ?
> sensor_specs.args[0] : 0)) {
> - pr_debug("sensor %pOFn id=%d belongs to %pOFn\n", sensor, id, child);
> + pr_debug("sensor %pOFP id=%d belongs to %pOFP\n", sensor, id, child);
> return no_free_ptr(child);
> }
> }
> @@ -180,7 +180,7 @@ static int thermal_of_monitor_init(struct device_node *np, int *delay, int *pdel
> if (ret == -EINVAL) {
> *pdelay = 0;
> } else if (ret < 0) {
> - pr_err("%pOFn: Couldn't get polling-delay-passive: %d\n", np, ret);
> + pr_err("%pOFP: Couldn't get polling-delay-passive: %d\n", np, ret);
> return ret;
> }
>
> @@ -188,7 +188,7 @@ static int thermal_of_monitor_init(struct device_node *np, int *delay, int *pdel
> if (ret == -EINVAL) {
> *delay = 0;
> } else if (ret < 0) {
> - pr_err("%pOFn: Couldn't get polling-delay: %d\n", np, ret);
> + pr_err("%pOFP: Couldn't get polling-delay: %d\n", np, ret);
> return ret;
> }
>
> @@ -380,23 +380,23 @@ static struct thermal_zone_device *thermal_of_zone_register(struct device_node *
> np = of_thermal_zone_find(sensor, id);
> if (IS_ERR(np)) {
> if (PTR_ERR(np) != -ENODEV)
> - pr_err("Failed to find thermal zone for %pOFn id=%d\n", sensor, id);
> + pr_err("Failed to find thermal zone for %pOFP id=%d\n", sensor, id);
> return ERR_CAST(np);
> }
>
> trips = thermal_of_trips_init(np, &ntrips);
> if (IS_ERR(trips)) {
> - pr_err("Failed to parse trip points for %pOFn id=%d\n", sensor, id);
> + pr_err("Failed to parse trip points for %pOFP id=%d\n", sensor, id);
> ret = PTR_ERR(trips);
> goto out_of_node_put;
> }
>
> if (!trips)
> - pr_info("No trip points found for %pOFn id=%d\n", sensor, id);
> + pr_info("No trip points found for %pOFP id=%d\n", sensor, id);
>
> ret = thermal_of_monitor_init(np, &delay, &pdelay);
> if (ret) {
> - pr_err("Failed to initialize monitoring delays from %pOFn\n", np);
> + pr_err("Failed to initialize monitoring delays from %pOFP\n", np);
> goto out_kfree_trips;
> }
>
> @@ -417,7 +417,7 @@ static struct thermal_zone_device *thermal_of_zone_register(struct device_node *
> pdelay, delay);
> if (IS_ERR(tz)) {
> ret = PTR_ERR(tz);
> - pr_err("Failed to register thermal zone %pOFn: %d\n", np, ret);
> + pr_err("Failed to register thermal zone %pOFP: %d\n", np, ret);
> goto out_kfree_trips;
> }
>
Thank you for the patch, LGTM.
Please add the tag and send the v2
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] thermal/of: Add OF node address to output message
2026-03-06 13:49 ` Lukasz Luba
@ 2026-03-06 14:41 ` Daniel Lezcano
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2026-03-06 14:41 UTC (permalink / raw)
To: Lukasz Luba, Alexander Stein
Cc: linux-pm, linux-kernel, Zhang Rui, Daniel Lezcano, Rafael J. Wysocki
On 3/6/26 14:49, Lukasz Luba wrote:
>
>
> On 3/5/26 16:35, Alexander Stein wrote:
>> Temperature sensors are supposed to have the DT node name
>> temperature-sensors. Having multiple ones the node name alone isn't very
>> helpful. Add the node address to make them more distinguishable.
>>
>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>> ---
[ ... ]
> Thank you for the patch, LGTM.
> Please add the tag and send the v2
No need to send a v2 for a tag, I'll take care of collecting them
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] thermal/of: Add OF node address to output message
2026-03-05 16:35 [PATCH 1/1] thermal/of: Add OF node address to output message Alexander Stein
2026-03-06 13:49 ` Lukasz Luba
@ 2026-03-06 17:47 ` Daniel Lezcano
1 sibling, 0 replies; 4+ messages in thread
From: Daniel Lezcano @ 2026-03-06 17:47 UTC (permalink / raw)
To: Alexander Stein, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui,
Lukasz Luba
Cc: linux-pm, linux-kernel
On 3/5/26 17:35, Alexander Stein wrote:
> Temperature sensors are supposed to have the DT node name
> temperature-sensors. Having multiple ones the node name alone isn't very
> helpful. Add the node address to make them more distinguishable.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-03-06 17:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-05 16:35 [PATCH 1/1] thermal/of: Add OF node address to output message Alexander Stein
2026-03-06 13:49 ` Lukasz Luba
2026-03-06 14:41 ` Daniel Lezcano
2026-03-06 17:47 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®