mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: Muhammad Mahdi Amirpour <ampr.mhd@gmail.com>
Cc: pmladek@suse.com, rostedt@goodmis.org, senozhatsky@chromium.org,
	linux-kernel@vger.kernel.org,
	Muhammad Mahdi Amirpour <ampr.mhd@gmail.com>
Subject: Re: [PATCH v2] printk: fix kernel-doc name for nbcon_write_context_is_braille
Date: Tue, 13 Oct 2026 17:32:02 +0206	[thread overview]
Message-ID: <871p9twrjp.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20261013151300.75966-1-ampr.mhd@gmail.com>

On 2026-10-13, Muhammad Mahdi Amirpour <ampr.mhd@gmail.com> wrote:
> Use the function name in the kerneldoc description.
>
> Fixes: c83e3d291243 ("braille: nbcon: Allow to use a serial console with NBCON API as Braille console")
> Signed-off-by: Muhammad Mahdi Amirpour <ampr.mhd@gmail.com>
> ---
>  kernel/printk/nbcon.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/printk/nbcon.c b/kernel/printk/nbcon.c
> index fb1b37741..5f8afaca8 100644
> --- a/kernel/printk/nbcon.c
> +++ b/kernel/printk/nbcon.c
> @@ -2005,7 +2005,8 @@ void nbcon_kdb_release(struct nbcon_write_context *wctxt)
>  }
>  
>  /**
> - * nbcon_is_braille - Checks whether the nbcon write context is using Braille console
> + * nbcon_write_context_is_braille - Checks whether the nbcon write context
> + *                                  is using Braille console

Generally we use tabs instead of spaces, but perhaps Petr can fix it up
on commit or maybe he does not care. Either way:

Reviewed-by: John Ogness <john.ogness@linutronix.de>

  reply	other threads:[~2026-10-13 15:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 16:31 [PATCH] " Muhammad Mahdi Amirpour
2026-10-13 14:46 ` John Ogness
2026-10-13 15:13 ` [PATCH v2] " Muhammad Mahdi Amirpour
2026-10-13 15:26   ` John Ogness [this message]
2026-10-14 13:22   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871p9twrjp.fsf@jogness.linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=ampr.mhd@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®