From: John Ogness <john.ogness@linutronix.de>
To: Muhammad Mahdi Amirpour <ampr.mhd@gmail.com>, pmladek@suse.com
Cc: rostedt@goodmis.org, senozhatsky@chromium.org,
linux-kernel@vger.kernel.org,
Muhammad Mahdi Amirpour <ampr.mhd@gmail.com>
Subject: Re: [PATCH] printk: fix kernel-doc name for nbcon_write_context_is_braille
Date: Tue, 13 Oct 2026 16:52:30 +0206 [thread overview]
Message-ID: <874iepwtdl.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20261006163141.304554-1-ampr.mhd@gmail.com>
On 2026-10-06, Muhammad Mahdi Amirpour <ampr.mhd@gmail.com> wrote:
>
Do we allow empty commit messages? The patch title says it all, so I
guess it is ok.
Now that Linus has pulled the Braille fix, please add:
Fixes: c83e3d291243 ("braille: nbcon: Allow to use a serial console with NBCON API as Braille console")
> Signed-off-by: Muhammad Mahdi Amirpour <ampr.mhd@gmail.com>
...
> diff --git a/kernel/printk/nbcon.c b/kernel/printk/nbcon.c
> index fb1b37741..6f9735f4b 100644
> --- a/kernel/printk/nbcon.c
> +++ b/kernel/printk/nbcon.c
> @@ -2005,7 +2005,7 @@ void nbcon_kdb_release(struct nbcon_write_context *wctxt)
> }
>
> /**
> - * nbcon_is_braille - Checks whether the nbcon write context is using Braille console
> + * nbcon_write_context_is_braille - Checks whether the nbcon write context is using Braille console
Please wrap the comment to 80 columns. You can see
nbcon_device_try_acquire() for an example of a wrapping short
kerneldoc description.
John Ogness
next prev parent reply other threads:[~2026-10-13 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 16:31 Muhammad Mahdi Amirpour
2026-10-13 14:46 ` John Ogness [this message]
2026-10-13 15:13 ` [PATCH v2] " Muhammad Mahdi Amirpour
2026-10-13 15:26 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874iepwtdl.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=ampr.mhd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®