* [PATCH v2 4/5] fat: fallback to buffered write in case of fallocatded region on direct IO
@ 2013-11-17 11:38 Namjae Jeon
2013-12-01 12:50 ` OGAWA Hirofumi
0 siblings, 1 reply; 3+ messages in thread
From: Namjae Jeon @ 2013-11-17 11:38 UTC (permalink / raw)
To: hirofumi, akpm
Cc: linux-fsdevel, linux-kernel, Namjae Jeon, Namjae Jeon, Amit Sahrawat
From: Namjae Jeon <namjae.jeon@samsung.com>
For normal cases of direct IO write, trying to seek to location greater
than file size, makes it fall back to buffered write to fill that region.
Similarly, in case for write in Fallocated region, make it fall
to buffered write.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Amit Sahrawat <a.sahrawat@samsung.com>
---
fs/fat/inode.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 12a37a9..c9fb9b6 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -217,6 +217,14 @@ static ssize_t fat_direct_IO(int rw, struct kiocb *iocb,
loff_t size = offset + iov_iter_count(iter);
if (MSDOS_I(inode)->mmu_private < size)
return 0;
+
+ /*
+ * In case of writing in fallocated region, return 0 and
+ * fallback to buffered write.
+ */
+ if (MSDOS_I(inode)->i_disksize >
+ round_up(i_size_read(inode), inode->i_sb->s_blocksize))
+ return 0;
}
/*
--
1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 4/5] fat: fallback to buffered write in case of fallocatded region on direct IO
2013-11-17 11:38 [PATCH v2 4/5] fat: fallback to buffered write in case of fallocatded region on direct IO Namjae Jeon
@ 2013-12-01 12:50 ` OGAWA Hirofumi
2013-12-05 14:16 ` Namjae Jeon
0 siblings, 1 reply; 3+ messages in thread
From: OGAWA Hirofumi @ 2013-12-01 12:50 UTC (permalink / raw)
To: Namjae Jeon; +Cc: akpm, linux-fsdevel, linux-kernel, Namjae Jeon, Amit Sahrawat
Namjae Jeon <linkinjeon@gmail.com> writes:
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 12a37a9..c9fb9b6 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -217,6 +217,14 @@ static ssize_t fat_direct_IO(int rw, struct kiocb *iocb,
> loff_t size = offset + iov_iter_count(iter);
> if (MSDOS_I(inode)->mmu_private < size)
> return 0;
> +
> + /*
> + * In case of writing in fallocated region, return 0 and
> + * fallback to buffered write.
> + */
> + if (MSDOS_I(inode)->i_disksize >
> + round_up(i_size_read(inode), inode->i_sb->s_blocksize))
> + return 0;
->mmu_private works instead of i_size?
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 4/5] fat: fallback to buffered write in case of fallocatded region on direct IO
2013-12-01 12:50 ` OGAWA Hirofumi
@ 2013-12-05 14:16 ` Namjae Jeon
0 siblings, 0 replies; 3+ messages in thread
From: Namjae Jeon @ 2013-12-05 14:16 UTC (permalink / raw)
To: OGAWA Hirofumi
Cc: akpm, linux-fsdevel, linux-kernel, Namjae Jeon, Amit Sahrawat
2013/12/1, OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>:
> Namjae Jeon <linkinjeon@gmail.com> writes:
>
>> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
>> index 12a37a9..c9fb9b6 100644
>> --- a/fs/fat/inode.c
>> +++ b/fs/fat/inode.c
>> @@ -217,6 +217,14 @@ static ssize_t fat_direct_IO(int rw, struct kiocb
>> *iocb,
>> loff_t size = offset + iov_iter_count(iter);
>> if (MSDOS_I(inode)->mmu_private < size)
>> return 0;
>> +
>> + /*
>> + * In case of writing in fallocated region, return 0 and
>> + * fallback to buffered write.
>> + */
>> + if (MSDOS_I(inode)->i_disksize >
>> + round_up(i_size_read(inode), inode->i_sb->s_blocksize))
>> + return 0;
>
> ->mmu_private works instead of i_size?
Yes, I will change it.
Thanks.
> --
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-05 14:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-17 11:38 [PATCH v2 4/5] fat: fallback to buffered write in case of fallocatded region on direct IO Namjae Jeon
2013-12-01 12:50 ` OGAWA Hirofumi
2013-12-05 14:16 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®