From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] filldir write data missing size
Date: Tue, 29 Jul 2008 05:14:37 +0900 [thread overview]
Message-ID: <871w1dvk9e.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20080728190749.GA20019@linux-sh.org> (Paul Mundt's message of "Tue, 29 Jul 2008 04:07:49 +0900")
Paul Mundt <lethal@linux-sh.org> writes:
> On Tue, Jul 22, 2008 at 06:31:12AM +0900, OGAWA Hirofumi wrote:
>> Yoshinori Sato <ysato@users.sourceforge.jp> writes:
>>
>> > This problem is sh-linux-gcc v4.1.2 and target sh2(a)-bigendian.
>> >
>> > "__put_user(s64, u32_ptr)" compiled.
>> >
>> > Correct code.
>> > *u32_ptr = s64 & 0xffffffff;
>> >
>> > Bad code.
>> > *u32_ptr = s64 >> 32;
>> >
>> > I'm add cast put_user 4byte case.
>>
>> I see. How about the following patch? I guess the problems of this type
>> should be fixed.
>>
> I merged a different workaround as no one bothered to CC me on this
> thread. Your fix looks more correct though, please provide a
> Signed-off-by for it and I'll take this over the previous workaround.
Of course. But I didn't test it at all, so please test it.
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2008-07-28 20:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-19 3:18 Yoshinori Sato
2008-07-19 17:24 ` OGAWA Hirofumi
2008-07-19 18:28 ` Yoshinori Sato
2008-07-19 20:11 ` OGAWA Hirofumi
2008-07-21 15:48 ` Yoshinori Sato
2008-07-21 21:31 ` OGAWA Hirofumi
2008-07-28 18:58 ` Yoshinori Sato
2008-07-28 19:07 ` Paul Mundt
2008-07-28 20:14 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871w1dvk9e.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@linux-foundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome