From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] filldir write data missing size
Date: Sun, 20 Jul 2008 05:11:29 +0900 [thread overview]
Message-ID: <87r69pk51q.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <87iqv1wwy1.wl%ysato@users.sourceforge.jp> (Yoshinori Sato's message of "Sat, 19 Jul 2008 14:28:06 -0400")
Yoshinori Sato <ysato@users.sourceforge.jp> writes:
>> > - if (__put_user(offset, &dirent->d_off))
>> > + if (__put_user((unsigned long)offset, &dirent->d_off))
>>
>> Um.. __put_user() should be already doing it automatically..
>
> I'm mistake.
>
> I checked object, and found bad code.
> This problem fix __put_user.
Um.. Could you explain the detail of problem? Is this a workaround or
something for the bug of some compiler? If so, shouldn't we fix
__put_user() instead of caller?
E.g. the following or something fixes it? (btw, this is for x86)
#define __put_user(x, ptr) ({ \
/* Since some compiler generates wrong code, we need __v.?? */ \
__typeof__(*(ptr)) __v = (x); \
__put_user_nocheck(__v, (ptr), sizeof(*(ptr))); \
})
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2008-07-19 20:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-19 3:18 Yoshinori Sato
2008-07-19 17:24 ` OGAWA Hirofumi
2008-07-19 18:28 ` Yoshinori Sato
2008-07-19 20:11 ` OGAWA Hirofumi [this message]
2008-07-21 15:48 ` Yoshinori Sato
2008-07-21 21:31 ` OGAWA Hirofumi
2008-07-28 18:58 ` Yoshinori Sato
2008-07-28 19:07 ` Paul Mundt
2008-07-28 20:14 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r69pk51q.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome