* [PATCH -next] drm/panfrost: Fix unused variable warning
@ 2020-11-02 9:33 Zou Wei
2020-11-02 9:29 ` Steven Price
0 siblings, 1 reply; 3+ messages in thread
From: Zou Wei @ 2020-11-02 9:33 UTC (permalink / raw)
To: robh, tomeu.vizoso, steven.price, alyssa.rosenzweig, airlied, daniel
Cc: dri-devel, linux-kernel, Zou Wei
Fixes the following W=1 kernel build warning:
./panfrost_job.c:617:28: warning: unused variable ‘js’ [-Wunused-variable]
struct panfrost_job_slot *js = pfdev->js;
^~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
drivers/gpu/drm/panfrost/panfrost_job.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
index 4902bc6..e75b7d2 100644
--- a/drivers/gpu/drm/panfrost/panfrost_job.c
+++ b/drivers/gpu/drm/panfrost/panfrost_job.c
@@ -613,8 +613,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv)
void panfrost_job_close(struct panfrost_file_priv *panfrost_priv)
{
- struct panfrost_device *pfdev = panfrost_priv->pfdev;
- struct panfrost_job_slot *js = pfdev->js;
int i;
for (i = 0; i < NUM_JOB_SLOTS; i++)
--
2.6.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] drm/panfrost: Fix unused variable warning
2020-11-02 9:33 [PATCH -next] drm/panfrost: Fix unused variable warning Zou Wei
@ 2020-11-02 9:29 ` Steven Price
2020-11-02 11:54 ` 答复: " Zouwei (Samuel)
0 siblings, 1 reply; 3+ messages in thread
From: Steven Price @ 2020-11-02 9:29 UTC (permalink / raw)
To: Zou Wei, robh, tomeu.vizoso, alyssa.rosenzweig, airlied, daniel
Cc: dri-devel, linux-kernel
On 02/11/2020 09:33, Zou Wei wrote:
> Fixes the following W=1 kernel build warning:
>
> ./panfrost_job.c:617:28: warning: unused variable ‘js’ [-Wunused-variable]
> struct panfrost_job_slot *js = pfdev->js;
> ^~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Boris posted an identical patch earlier:
https://lore.kernel.org/r/20201101173817.831769-1-boris.brezillon%40collabora.com
Steve
> ---
> drivers/gpu/drm/panfrost/panfrost_job.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 4902bc6..e75b7d2 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -613,8 +613,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv)
>
> void panfrost_job_close(struct panfrost_file_priv *panfrost_priv)
> {
> - struct panfrost_device *pfdev = panfrost_priv->pfdev;
> - struct panfrost_job_slot *js = pfdev->js;
> int i;
>
> for (i = 0; i < NUM_JOB_SLOTS; i++)
>
^ permalink raw reply [flat|nested] 3+ messages in thread* 答复: [PATCH -next] drm/panfrost: Fix unused variable warning
2020-11-02 9:29 ` Steven Price
@ 2020-11-02 11:54 ` Zouwei (Samuel)
0 siblings, 0 replies; 3+ messages in thread
From: Zouwei (Samuel) @ 2020-11-02 11:54 UTC (permalink / raw)
To: Steven Price, robh, tomeu.vizoso, alyssa.rosenzweig, airlied, daniel
Cc: dri-devel, linux-kernel
Hi Steve,
Sorry, I didn't notice the patch earlier.
Please ignore my patch.
-----邮件原件-----
发件人: Steven Price [mailto:steven.price@arm.com]
发送时间: 2020年11月2日 17:29
收件人: Zouwei (Samuel) <zou_wei@huawei.com>; robh@kernel.org; tomeu.vizoso@collabora.com; alyssa.rosenzweig@collabora.com; airlied@linux.ie; daniel@ffwll.ch
抄送: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH -next] drm/panfrost: Fix unused variable warning
On 02/11/2020 09:33, Zou Wei wrote:
> Fixes the following W=1 kernel build warning:
>
> ./panfrost_job.c:617:28: warning: unused variable ‘js’ [-Wunused-variable]
> struct panfrost_job_slot *js = pfdev->js;
> ^~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Boris posted an identical patch earlier:
https://lore.kernel.org/r/20201101173817.831769-1-boris.brezillon%40collabora.com
Steve
> ---
> drivers/gpu/drm/panfrost/panfrost_job.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 4902bc6..e75b7d2 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -613,8 +613,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv)
>
> void panfrost_job_close(struct panfrost_file_priv *panfrost_priv)
> {
> - struct panfrost_device *pfdev = panfrost_priv->pfdev;
> - struct panfrost_job_slot *js = pfdev->js;
> int i;
>
> for (i = 0; i < NUM_JOB_SLOTS; i++)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-02 11:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02 9:33 [PATCH -next] drm/panfrost: Fix unused variable warning Zou Wei
2020-11-02 9:29 ` Steven Price
2020-11-02 11:54 ` 答复: " Zouwei (Samuel)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®