mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [RFC PATCH] ALSA: hda/realtek: fix missing chained flag in fixup
@ 2026-11-15 13:22 Sungwoo Kim
  2026-11-15 13:26 ` Sungwoo Kim
  2026-11-16 12:25 ` Takashi Iwai
  0 siblings, 2 replies; 4+ messages in thread
From: Sungwoo Kim @ 2026-11-15 13:22 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai
  Cc: Dave Tian, Sungwoo Kim, linux-sound, linux-kernel

The fixup specifies a chain_id but does not set the chained flag,
which prevents the chained fixup from being executed.

Should chained be set to true here?

This was identified through static analysis and has not been tested
on actual hardware.

Signed-off-by: Sungwoo Kim <iam@sung-woo.kim>
---
 sound/hda/codecs/realtek/alc269.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 96fa8c2782bb..1be2e609c28d 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -6431,6 +6431,7 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ 0x1e, 0x411111f0 },
 			{ }
 		},
+		.chained = true,
 		.chain_id = ALC269_FIXUP_DMIC,
 	},
 	[ALC269_FIXUP_CZC_TMI] = {
@@ -6449,6 +6450,7 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ 0x20, 0x8000ffff },
 			{ }
 		},
+		.chained = true,
 		.chain_id = ALC269_FIXUP_DMIC,
 	},
 	[ALC269_FIXUP_CZC_L101] = {
@@ -6467,6 +6469,7 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ 0x1e, 0x411111f0 },
 			{ }
 		},
+		.chained = true,
 		.chain_id = ALC269_FIXUP_DMIC,
 	},
 	[ALC269_FIXUP_LEMOTE_A1802] = {
@@ -6485,6 +6488,7 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ 0x21, 0x03214020 },
 			{ }
 		},
+		.chained = true,
 		.chain_id = ALC269_FIXUP_DMIC,
 	},
 	[ALC269_FIXUP_LEMOTE_A190X] = {
@@ -6497,6 +6501,7 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ 0x1b, 0x0201401f }, /* front lineout */
 			{ }
 		},
+		.chained = true,
 		.chain_id = ALC269_FIXUP_DMIC,
 	},
 	[ALC256_FIXUP_INTEL_NUC8_RUGGED] = {
-- 
2.47.3


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFC PATCH] ALSA: hda/realtek: fix missing chained flag in fixup
  2026-11-15 13:22 [RFC PATCH] ALSA: hda/realtek: fix missing chained flag in fixup Sungwoo Kim
@ 2026-11-15 13:26 ` Sungwoo Kim
  2026-11-15 13:35   ` Sungwoo Kim
  2026-11-16 12:25 ` Takashi Iwai
  1 sibling, 1 reply; 4+ messages in thread
From: Sungwoo Kim @ 2026-11-15 13:26 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai; +Cc: Dave Tian, linux-sound, linux-kernel

One more, ALC668_FIXUP_ASUS_Nx51_HEADSET_MODE in alc662.c also has the
same issue (missing .chained=true)

On Sun, Nov 15, 2026 at 8:23 AM Sungwoo Kim <iam@sung-woo.kim> wrote:
>
> The fixup specifies a chain_id but does not set the chained flag,
> which prevents the chained fixup from being executed.
>
> Should chained be set to true here?
>
> This was identified through static analysis and has not been tested
> on actual hardware.
>
> Signed-off-by: Sungwoo Kim <iam@sung-woo.kim>
> ---
>  sound/hda/codecs/realtek/alc269.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 96fa8c2782bb..1be2e609c28d 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -6431,6 +6431,7 @@ static const struct hda_fixup alc269_fixups[] = {
>                         { 0x1e, 0x411111f0 },
>                         { }
>                 },
> +               .chained = true,
>                 .chain_id = ALC269_FIXUP_DMIC,
>         },
>         [ALC269_FIXUP_CZC_TMI] = {
> @@ -6449,6 +6450,7 @@ static const struct hda_fixup alc269_fixups[] = {
>                         { 0x20, 0x8000ffff },
>                         { }
>                 },
> +               .chained = true,
>                 .chain_id = ALC269_FIXUP_DMIC,
>         },
>         [ALC269_FIXUP_CZC_L101] = {
> @@ -6467,6 +6469,7 @@ static const struct hda_fixup alc269_fixups[] = {
>                         { 0x1e, 0x411111f0 },
>                         { }
>                 },
> +               .chained = true,
>                 .chain_id = ALC269_FIXUP_DMIC,
>         },
>         [ALC269_FIXUP_LEMOTE_A1802] = {
> @@ -6485,6 +6488,7 @@ static const struct hda_fixup alc269_fixups[] = {
>                         { 0x21, 0x03214020 },
>                         { }
>                 },
> +               .chained = true,
>                 .chain_id = ALC269_FIXUP_DMIC,
>         },
>         [ALC269_FIXUP_LEMOTE_A190X] = {
> @@ -6497,6 +6501,7 @@ static const struct hda_fixup alc269_fixups[] = {
>                         { 0x1b, 0x0201401f }, /* front lineout */
>                         { }
>                 },
> +               .chained = true,
>                 .chain_id = ALC269_FIXUP_DMIC,
>         },
>         [ALC256_FIXUP_INTEL_NUC8_RUGGED] = {
> --
> 2.47.3
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFC PATCH] ALSA: hda/realtek: fix missing chained flag in fixup
  2026-11-15 13:26 ` Sungwoo Kim
@ 2026-11-15 13:35   ` Sungwoo Kim
  0 siblings, 0 replies; 4+ messages in thread
From: Sungwoo Kim @ 2026-11-15 13:35 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai; +Cc: Dave Tian, linux-sound, linux-kernel

One more, sorry for the multiple followups: CXT_PINCFG_LENOVO_NOTEBOOK
in conexant.c.


On Sun, Nov 15, 2026 at 8:26 AM Sungwoo Kim <iam@sung-woo.kim> wrote:
>
> One more, ALC668_FIXUP_ASUS_Nx51_HEADSET_MODE in alc662.c also has the
> same issue (missing .chained=true)
>
> On Sun, Nov 15, 2026 at 8:23 AM Sungwoo Kim <iam@sung-woo.kim> wrote:
> >
> > The fixup specifies a chain_id but does not set the chained flag,
> > which prevents the chained fixup from being executed.
> >
> > Should chained be set to true here?
> >
> > This was identified through static analysis and has not been tested
> > on actual hardware.
> >
> > Signed-off-by: Sungwoo Kim <iam@sung-woo.kim>
> > ---
> >  sound/hda/codecs/realtek/alc269.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> > index 96fa8c2782bb..1be2e609c28d 100644
> > --- a/sound/hda/codecs/realtek/alc269.c
> > +++ b/sound/hda/codecs/realtek/alc269.c
> > @@ -6431,6 +6431,7 @@ static const struct hda_fixup alc269_fixups[] = {
> >                         { 0x1e, 0x411111f0 },
> >                         { }
> >                 },
> > +               .chained = true,
> >                 .chain_id = ALC269_FIXUP_DMIC,
> >         },
> >         [ALC269_FIXUP_CZC_TMI] = {
> > @@ -6449,6 +6450,7 @@ static const struct hda_fixup alc269_fixups[] = {
> >                         { 0x20, 0x8000ffff },
> >                         { }
> >                 },
> > +               .chained = true,
> >                 .chain_id = ALC269_FIXUP_DMIC,
> >         },
> >         [ALC269_FIXUP_CZC_L101] = {
> > @@ -6467,6 +6469,7 @@ static const struct hda_fixup alc269_fixups[] = {
> >                         { 0x1e, 0x411111f0 },
> >                         { }
> >                 },
> > +               .chained = true,
> >                 .chain_id = ALC269_FIXUP_DMIC,
> >         },
> >         [ALC269_FIXUP_LEMOTE_A1802] = {
> > @@ -6485,6 +6488,7 @@ static const struct hda_fixup alc269_fixups[] = {
> >                         { 0x21, 0x03214020 },
> >                         { }
> >                 },
> > +               .chained = true,
> >                 .chain_id = ALC269_FIXUP_DMIC,
> >         },
> >         [ALC269_FIXUP_LEMOTE_A190X] = {
> > @@ -6497,6 +6501,7 @@ static const struct hda_fixup alc269_fixups[] = {
> >                         { 0x1b, 0x0201401f }, /* front lineout */
> >                         { }
> >                 },
> > +               .chained = true,
> >                 .chain_id = ALC269_FIXUP_DMIC,
> >         },
> >         [ALC256_FIXUP_INTEL_NUC8_RUGGED] = {
> > --
> > 2.47.3
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFC PATCH] ALSA: hda/realtek: fix missing chained flag in fixup
  2026-11-15 13:22 [RFC PATCH] ALSA: hda/realtek: fix missing chained flag in fixup Sungwoo Kim
  2026-11-15 13:26 ` Sungwoo Kim
@ 2026-11-16 12:25 ` Takashi Iwai
  1 sibling, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2026-11-16 12:25 UTC (permalink / raw)
  To: Sungwoo Kim
  Cc: Jaroslav Kysela, Takashi Iwai, Dave Tian, linux-sound, linux-kernel

On Sun, 15 Nov 2026 14:22:15 +0100,
Sungwoo Kim wrote:
> 
> The fixup specifies a chain_id but does not set the chained flag,
> which prevents the chained fixup from being executed.
> 
> Should chained be set to true here?
> 
> This was identified through static analysis and has not been tested
> on actual hardware.
> 
> Signed-off-by: Sungwoo Kim <iam@sung-woo.kim>

Interesting, and yes, the flag should have been set to make the
chain_id effective.  OTOH, those entries are all pin-config updates
for Loongson & co, and ALC269_FIXUP_DMIC is also the pin-config
update, so I guess your change is superfluous or breaking.

I'd rather delete or comment out those dead lines unless anyone
actually hitting the problem, instead.


thanks,

Takashi

> ---
>  sound/hda/codecs/realtek/alc269.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 96fa8c2782bb..1be2e609c28d 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -6431,6 +6431,7 @@ static const struct hda_fixup alc269_fixups[] = {
>  			{ 0x1e, 0x411111f0 },
>  			{ }
>  		},
> +		.chained = true,
>  		.chain_id = ALC269_FIXUP_DMIC,
>  	},
>  	[ALC269_FIXUP_CZC_TMI] = {
> @@ -6449,6 +6450,7 @@ static const struct hda_fixup alc269_fixups[] = {
>  			{ 0x20, 0x8000ffff },
>  			{ }
>  		},
> +		.chained = true,
>  		.chain_id = ALC269_FIXUP_DMIC,
>  	},
>  	[ALC269_FIXUP_CZC_L101] = {
> @@ -6467,6 +6469,7 @@ static const struct hda_fixup alc269_fixups[] = {
>  			{ 0x1e, 0x411111f0 },
>  			{ }
>  		},
> +		.chained = true,
>  		.chain_id = ALC269_FIXUP_DMIC,
>  	},
>  	[ALC269_FIXUP_LEMOTE_A1802] = {
> @@ -6485,6 +6488,7 @@ static const struct hda_fixup alc269_fixups[] = {
>  			{ 0x21, 0x03214020 },
>  			{ }
>  		},
> +		.chained = true,
>  		.chain_id = ALC269_FIXUP_DMIC,
>  	},
>  	[ALC269_FIXUP_LEMOTE_A190X] = {
> @@ -6497,6 +6501,7 @@ static const struct hda_fixup alc269_fixups[] = {
>  			{ 0x1b, 0x0201401f }, /* front lineout */
>  			{ }
>  		},
> +		.chained = true,
>  		.chain_id = ALC269_FIXUP_DMIC,
>  	},
>  	[ALC256_FIXUP_INTEL_NUC8_RUGGED] = {
> -- 
> 2.47.3
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-16 12:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-15 13:22 [RFC PATCH] ALSA: hda/realtek: fix missing chained flag in fixup Sungwoo Kim
2026-11-15 13:26 ` Sungwoo Kim
2026-11-15 13:35   ` Sungwoo Kim
2026-11-16 12:25 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®