From: "Eric W. Biederman" <ebiederm@xmission.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Avi Weiss <thnkslprpt@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christian Brauner <brauner@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] signal: respect the blocked mask in dequeue_synchronous_signal()
Date: Fri, 23 Oct 2026 16:28:16 +0000 [thread overview]
Message-ID: <8733twnzz3.fsf@email.froward.int.ebiederm.org> (raw)
In-Reply-To: <atswnpqj8VHJwqu9@redhat.com> (Oleg Nesterov's message of "Fri, 23 Oct 2026 12:02:06 +0200")
Oleg Nesterov <oleg@redhat.com> writes:
> On 10/22, Eric W. Biederman wrote:
>>
>> Oleg Nesterov <oleg@redhat.com> writes:
>>
>> > And afaics we have another problem. sys_rt_sigqueueinfo() allows to
>> > send a SI_FROMKERNEL RT signal to itself.
>>
>> I don't see where your proposed code is addressing this.
>
> Hmm. It doesn't even try. And yes, I know it is deliberate, I know that
> CRIU uses this feature.
>
>> > In this case sigmask(q->info.si_signo) leads to UB on 32-bit.
>>
>> I presume you are referring to a signal number that exceeds 32
>> being put into a 32bit mask. That does seem worth fixing.
>
> Yes. That is all. I just tried to explain why this can happen.
> sys_rt_sigqueueinfo() is the reason. The kernel doesn't sent
> SI_FROMKERNEL signals with si_signo >= SIGRTMIN.
Oh I see. I thought you were saying it was a bug that
sys_rt_sigqueue_info could send those signals, not that
it sending those signals would cause us problems.
Eric
next prev parent reply other threads:[~2026-10-23 16:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 6:10 Avi Weiss
2026-10-22 11:58 ` Oleg Nesterov
2026-10-22 20:21 ` Eric W. Biederman
2026-10-23 10:02 ` Oleg Nesterov
2026-10-23 16:28 ` Eric W. Biederman [this message]
2026-10-22 20:15 ` Eric W. Biederman
2026-10-23 10:48 ` [PATCH] signal: cleanup the .si_signo checks " Oleg Nesterov
2026-10-23 10:50 ` Oleg Nesterov
2026-10-23 16:46 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8733twnzz3.fsf@email.froward.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=thnkslprpt@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®